-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
805 trigger storage of cah on workstep execution #821
Merged
ognjenkurtic
merged 10 commits into
develop
from
805-trigger-storage-of-cah-on-workstep-execution
Jul 25, 2024
Merged
805 trigger storage of cah on workstep execution #821
ognjenkurtic
merged 10 commits into
develop
from
805-trigger-storage-of-cah-on-workstep-execution
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ognjenkurtic
requested review from
skarred14,
Therecanbeonlyone1969,
Kasshern,
Ybittan,
biscuitdey and
skosito
as code owners
July 23, 2024 14:31
…local network to env
…for ccontract deployment
…nd workstep instance id
ognjenkurtic
force-pushed
the
805-trigger-storage-of-cah-on-workstep-execution
branch
from
July 24, 2024 19:36
4ee5aac
to
bf0f783
Compare
@Therecanbeonlyone1969 @biscuitdey ready for review |
Therecanbeonlyone1969
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ognjenkurtic
deleted the
805-trigger-storage-of-cah-on-workstep-execution
branch
July 25, 2024 07:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Triggers storage of CAH on the BPI smart contract defined in the env after a succesfully transation execution.
Related Issue
#805
Motivation and Context
CAH has to be stored onchain for subsequent verification by a third party
How Has This Been Tested
Verified that the e2e test is still green.
Screenshots (if appropriate)
Types of changes
Checklist