Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

805 trigger storage of cah on workstep execution #821

Merged
merged 10 commits into from
Jul 25, 2024

Conversation

ognjenkurtic
Copy link
Collaborator

Description

Triggers storage of CAH on the BPI smart contract defined in the env after a succesfully transation execution.

Related Issue

#805

Motivation and Context

CAH has to be stored onchain for subsequent verification by a third party

How Has This Been Tested

Verified that the e2e test is still green.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

@ognjenkurtic ognjenkurtic changed the base branch from main to develop July 23, 2024 14:31
@ognjenkurtic ognjenkurtic force-pushed the 805-trigger-storage-of-cah-on-workstep-execution branch from 4ee5aac to bf0f783 Compare July 24, 2024 19:36
@ognjenkurtic
Copy link
Collaborator Author

@Therecanbeonlyone1969 @biscuitdey ready for review

Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ognjenkurtic ognjenkurtic merged commit 925bd60 into develop Jul 25, 2024
2 checks passed
@ognjenkurtic ognjenkurtic deleted the 805-trigger-storage-of-cah-on-workstep-execution branch July 25, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants