Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

814 sri extend the e2e test to verify the cah was created from the public inputs payload and accompanying witness #822

Merged
merged 5 commits into from
Jul 25, 2024
Merged

814 sri extend the e2e test to verify the cah was created from the public inputs payload and accompanying witness #822

merged 5 commits into from
Jul 25, 2024

Conversation

ognjenkurtic
Copy link
Collaborator

Description

Extends the e2e test to verify that the CAH is stored on chain after each tx execution, and that it matches the leaf value in the state tree.

Related Issue

#814

Motivation and Context

Verifies tx execution

How Has This Been Tested

Ran the e2e test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

@ognjenkurtic ognjenkurtic force-pushed the 814-sri-extend-the-e2e-test-to-verify-the-cah-was-created-from-the-public-inputs-payload-and-accompanying-witness branch from 1e16a2b to cb7de16 Compare July 25, 2024 13:37
@ognjenkurtic
Copy link
Collaborator Author

@Therecanbeonlyone1969 ready

Therecanbeonlyone1969
Therecanbeonlyone1969 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ognjenkurtic ognjenkurtic merged commit 6145e55 into develop Jul 25, 2024
2 checks passed
@ognjenkurtic ognjenkurtic deleted the 814-sri-extend-the-e2e-test-to-verify-the-cah-was-created-from-the-public-inputs-payload-and-accompanying-witness branch July 25, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therecanbeonlyone1969 Therecanbeonlyone1969 Therecanbeonlyone1969 approved these changes

@skarred14 skarred14 Awaiting requested review from skarred14

@Kasshern Kasshern Awaiting requested review from Kasshern

@Ybittan Ybittan Awaiting requested review from Ybittan

@biscuitdey biscuitdey Awaiting requested review from biscuitdey

@skosito skosito Awaiting requested review from skosito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ognjenkurtic @Therecanbeonlyone1969