Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRI milestone 5 #824

Merged
merged 124 commits into from
Jul 28, 2024
Merged

SRI milestone 5 #824

merged 124 commits into from
Jul 28, 2024

Conversation

ognjenkurtic
Copy link
Collaborator

Description

Includes remaining changes for the SRI implementation that were merged into develop for the sake of efficiency.

Related Issue

Bunch of SRI issues

Motivation and Context

Place the final SRI implemenation on main.

How Has This Been Tested

unit and e2e tests are extended to cover the full SRI use-case

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

biscuitdey and others added 30 commits June 20, 2024 13:58
@biscuitdey
Create Ccsm.sol contract
3306c53
@biscuitdey
Add setAnchorHash function
e2176bd
@biscuitdey
Add getAnchorHash function
8987510
@biscuitdey
Fix formatting
fbb9cf7
@ognjenkurtic
add develop branch to bri-3.yml file
779ad91
@biscuitdey
Add access control to contract
4651530
@biscuitdey
Bug fix
239b8d5
@biscuitdey @ognjenkurtic
Updated etherjs packages
52ed45d
@biscuitdey @ognjenkurtic
Remove unnecesary files
c3d3633
@biscuitdey @ognjenkurtic
Revert "Remove unnecesary files"
2827151 
This reverts commit c080c95.
@biscuitdey @ognjenkurtic
Fix hardhat dependency
31da6f3
@biscuitdey @ognjenkurtic
Fix imports
128732a
@biscuitdey @ognjenkurtic
Add Workstep2 artifacts
a9be4f0
@biscuitdey @ognjenkurtic
Add Workstep3 artifacts
80f6aa7
@biscuitdey
Merge branch 'develop' into feature/797-create-smart-contract
4e2ac90
@biscuitdey
Bug fix
3b4687f
@biscuitdey
Merge pull request #798 from ethereum-oasis-op/feature/797-create-sma…
e727269 
…rt-contract

Feature/797 create smart contract
@ognjenkurtic
Remove unnecessary params from prepareInputs call in circuitService i…
f56d12c 
…nterface
@ognjenkurtic
MOve prepareInputs to transaction agent level as preparation for refa…
5a766d0 
…ctor
@ognjenkurtic
Refactor circuit input preparation to split public and payload inputs
6f3f399
@ognjenkurtic
Use circuitInputsParserService in tx agent to prep inputs WIP
bf17f4d
@ognjenkurtic
Introduce parsing of arrays of objects to cirucit input parser
ae51812
@ognjenkurtic
Extend the e2e test to use a mapping to translate tx payload into cir…
16c6bec 
…cuit inputs
@ognjenkurtic
Refactor trasaction agent executeTransaction method for better readab…
02e5224 
…ility
@ognjenkurtic
Fix formatting
f64347d
@biscuitdey
Update hardhat config
0373142
@biscuitdey
Compile ccsm contract using hardhat
88b21bd
@biscuitdey
Add string verification in the ccsm contract
9f4ef0f
@biscuitdey
Add alchemy connection env values
ad1dc90
@biscuitdey
Add ccsm interface
463fd49
@ognjenkurtic
Run formatting
cb05b98
@ognjenkurtic
Use 127.0.0.1 instead of localhost for hardhat node
ea52e29
@ognjenkurtic
Dummy commit to trigger GH action
55ddbbd
@ognjenkurtic
...
925bd60
@ognjenkurtic
Update ccsmArtifacts with latest changes
853b477
@ognjenkurtic
Extend the e2e test to verify proper storage of CAH on chain
eedc526
@ognjenkurtic
Run formatting
45c7d14
@ognjenkurtic
Wait for HH to be killed before exiting the e2e bash script
e6266d9
@ognjenkurtic
Remove resolved TODO
6145e55
@ognjenkurtic
Add workstep verifier contracts from the sri use-case to hardhhat deploy
a2c732d
@ognjenkurtic
add workstep verifier contract artifacts to zkartifacts folder
3e4c7df
@ognjenkurtic
Remove obsoelte method for contract connection from ethereum service …
b6f16f7 
…public api and remove obsolete tests
@ognjenkurtic
WIP verify proof in transaction execution
8faa7bd
@ognjenkurtic
Implement on chain verifiction for workstep1 from use-case
9adf3b5
@ognjenkurtic
Run formatting
ce83c83
@ognjenkurtic
Add verifier contract address to workstep model and execute respectiv…
2f56ec1 
…e verifier on workste execution
@ognjenkurtic
Fix fomratting
1d417d5
@ognjenkurtic
Fix tests
e72c01e
@ognjenkurtic
Remove commented out import
5ba07c3
@ognjenkurtic
Rem obsolete TODOs
47ef994
Therecanbeonlyone1969
Therecanbeonlyone1969 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all PRs on development going into this PR. LGTM!

Congratulations, BRI3 team! Well done. A long journey si coming to an end!

biscuitdey
biscuitdey approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@biscuitdey biscuitdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations team! This has been a fun journey~

@ognjenkurtic ognjenkurtic merged commit 7df0ea5 into main Jul 28, 2024
5 checks passed
@ognjenkurtic ognjenkurtic deleted the develop branch July 28, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therecanbeonlyone1969 Therecanbeonlyone1969 Therecanbeonlyone1969 approved these changes

@biscuitdey biscuitdey biscuitdey approved these changes

@skarred14 skarred14 Awaiting requested review from skarred14 skarred14 is a code owner

@Kasshern Kasshern Awaiting requested review from Kasshern Kasshern is a code owner

@Ybittan Ybittan Awaiting requested review from Ybittan Ybittan is a code owner

@skosito skosito Awaiting requested review from skosito skosito is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ognjenkurtic @biscuitdey @Therecanbeonlyone1969