Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optimism submodule version to 24a8d3e #59

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

pcw109550
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.39%. Comparing base (c7d4977) to head (da047d3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   70.39%   70.39%           
=======================================
  Files          19       19           
  Lines        2810     2810           
=======================================
  Hits         1978     1978           
  Misses        743      743           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcw109550 pcw109550 force-pushed the tip/pcw109550/optimism-24a8d3e branch from 27607a7 to da047d3 Compare April 23, 2024 20:51
@pcw109550 pcw109550 requested a review from ImTei April 23, 2024 21:07
@pcw109550 pcw109550 marked this pull request as ready for review April 23, 2024 21:07
@ImTei
Copy link
Collaborator

ImTei commented Apr 23, 2024

Can you describe changes on CI?

@pcw109550
Copy link
Collaborator Author

pcw109550 commented Apr 23, 2024

@ImTei ethereum-optimism/optimism#10106 makes allocs-l2.json required to run op-e2e. I added changes to store them in circleci workspace. Refer https://github.com/ethereum-optimism/optimism/pull/10106/files#diff-0e6bcf428670189ddd65ef0f28b56c3afd69a472d83ab272407c5c2df7523939. Also, FPAC alloc are not used so removed.

@pcw109550 pcw109550 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit b02bc5d Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants