-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OptimismPortal wd invalidation mitigation #77
Conversation
Introduces a proposal that would prevent user withdrawals in the OptimismPortal from being invalidated any time that the fallback is utilized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favour of this change. The validity checks are still really simple and it gives the guardian significantly more flexibility. The concern about user impact affects the guardian decision making process even if the actual impact winds up being small so providing better tools to simplify the decision making process seems well worth it to me.
Co-authored-by: Ed Mazurek <Edward.R.Mazurek@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Simple enough to change up. Also will include some changes to the deputy guardian.
Reminder to self: do not allow invalidation timestamp to be greater than current timestamp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, and let a comment but the rest looks a nice initiative to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; looks like this doc defers on variable naming, i'll assume it comes during spec/impl phase 👍
@smartcontracts a bit late to the game here, but wondering if there will be a way to have presigned fallbacks to the permissioned game that do invalidate all existing games (for incident response scenario). was chatting with @elihaims about this today and this could be really helpful to prevent a scenario in which we need to pause the whole bridge to remedy a widespread issue |
Fallback can be triggered by the Worth noting that you would need to have pre-signed fallbacks that have the same nonces as pre-signed pauses, but that's fine imo. |
Introduces a proposal that would prevent user withdrawals in the OptimismPortal from being invalidated any time that the fallback is utilized.