-
Notifications
You must be signed in to change notification settings - Fork 265
Update schemas.mdx #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schemas.mdx #1024
Conversation
adding two new schemas: metagov contribution and foundation mission request completed
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Warning Rate limit exceeded@krofax has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 34 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe pull request introduces updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
pages/chain/identity/schemas.mdx (1)
132-132
: Consider removing or clarifying unused fields.The fields "Impact" and "MetadataUrl" are marked as "not currently being used". Consider either:
- Removing these fields if they won't be used in the near future
- Adding a note about when they will be used
- Providing context about their intended purpose
Also applies to: 136-136
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- pages/chain/identity/schemas.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/chain/identity/schemas.mdx (1)
Pattern
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
- For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
"
🪛 GitHub Check: lint
pages/chain/identity/schemas.mdx
[warning] 124-124:
Found reference to undefined definition
[warning] 124-124:
Don’t use literal URLs without angle brackets
[warning] 130-130:
Missing final pipe in table fence
[warning] 135-135:
Cell should be padded with 1 space, not 6
[warning] 138-138:
Found reference to undefined definition
[warning] 138-138:
Don’t use literal URLs without angle brackets
[warning] 143-143:
Cell should be padded with 1 space, not 10
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
pages/chain/identity/schemas.mdx (1)
131-131
: Consider removing or clarifying unused fields.The fields
Impact
andMetadataUrl
are marked as "not currently being used". Consider either:
- Removing these fields if they're not planned for use
- Adding a note about their intended future use
Also applies to: 135-135
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- pages/chain/identity/schemas.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/chain/identity/schemas.mdx (1)
Pattern
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
- For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
"
🪛 GitHub Check: lint
pages/chain/identity/schemas.mdx
[warning] 129-129:
Missing final pipe in table fence
[warning] 134-134:
Cell should be padded with 1 space, not 6
[warning] 141-141:
Cell should be padded with 1 space, not 10
🔇 Additional comments (4)
pages/chain/identity/schemas.mdx (4)
124-124
: Fix Markdown link formatting.Remove the space between the link text and URL.
-### [MetaGov Contribution] (https://optimism.easscan.org/schema/view/0x84260b9102b41041692558a4e0cba6b7e5f9b813be56402c3db820c06dd4a5f1) +### [MetaGov Contribution](https://optimism.easscan.org/schema/view/0x84260b9102b41041692558a4e0cba6b7e5f9b813be56402c3db820c06dd4a5f1)
125-136
: Standardize table formatting.Fix the following table formatting issues:
- Add missing final pipe in table rows
- Ensure consistent single-space padding in cells
🧰 Tools
🪛 GitHub Check: lint
[warning] 129-129:
Missing final pipe in table fence
[warning] 134-134:
Cell should be padded with 1 space, not 6
137-137
: Fix Markdown link formatting.Remove the space between the link text and URL.
-### [Foundation Mission Request Completed] (https://optimism.easscan.org/schema/view/0x649cc6df5af7561b66384405a62682c44e2428584d2f17a202ac3ef4506e2457) +### [Foundation Mission Request Completed](https://optimism.easscan.org/schema/view/0x649cc6df5af7561b66384405a62682c44e2428584d2f17a202ac3ef4506e2457)
138-144
: Standardize table formatting.Ensure consistent single-space padding in table cells.
🧰 Tools
🪛 GitHub Check: lint
[warning] 141-141:
Cell should be padded with 1 space, not 10
adding two new schemas: metagov contribution and foundation mission request completed
Description
added two new schemas: metagov contribution and foundation mission request completed
Tests
none
Additional context
n/a
Metadata