-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caveat for the priority fee #1071
Add caveat for the priority fee #1071
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Caution Review failedThe pull request is closed. WalkthroughThe pull request modifies the documentation on transaction fees for OP Mainnet, enhancing clarity and detail. Key updates include an expanded description of the priority fee, emphasizing its optional nature and potential minimum values imposed by wallets. The L1 Data Fee section now clarifies that it is automatically charged for transactions and cannot currently be limited. Additionally, the document details the L1 Data Fee calculation before and after the Ecotone upgrade, explaining changes in transaction batch posting and the introduction of the Fjord upgrade. Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
This update clarifies that, although the priority fee in the OP Stack can technically be set to 0, certain wallet and mempool implementations, like Geth, may impose a minimum fee, usually 1 wei or a configurable default of 1 gwei.
Include a link to any github issues that this may close in the following form: