Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caveat for the priority fee #1071

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

richardgreg
Copy link
Contributor

Description

This update clarifies that, although the priority fee in the OP Stack can technically be set to 0, certain wallet and mempool implementations, like Geth, may impose a minimum fee, usually 1 wei or a configurable default of 1 gwei.

Include a link to any github issues that this may close in the following form:

@richardgreg richardgreg requested a review from a team as a code owner November 5, 2024 09:33
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit aa0b7d0
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/672a3ed4316d9c00083bc12b
😎 Deploy Preview https://deploy-preview-1071--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krofax krofax merged commit 4cd8a1d into ethereum-optimism:main Nov 5, 2024
6 of 7 checks passed
Copy link
Contributor

coderabbitai bot commented Nov 5, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the documentation on transaction fees for OP Mainnet, enhancing clarity and detail. Key updates include an expanded description of the priority fee, emphasizing its optional nature and potential minimum values imposed by wallets. The L1 Data Fee section now clarifies that it is automatically charged for transactions and cannot currently be limited. Additionally, the document details the L1 Data Fee calculation before and after the Ecotone upgrade, explaining changes in transaction batch posting and the introduction of the Fjord upgrade.

Changes

File Path Change Summary
pages/stack/transactions/fees.mdx Expanded description of the priority fee, clarified L1 Data Fee charging, and detailed fee calculations before and after Ecotone upgrade. Mentioned Fjord upgrade and its impact on L1 data usage charges.

Assessment against linked issues

Objective Addressed Explanation
Add caveat for the priority fee (Issue #559)

Possibly related issues

Possibly related PRs


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add caveat for the priority fee
2 participants