Skip to content

remove wallet & cex section #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged

remove wallet & cex section #1081

merged 1 commit into from
Nov 7, 2024

Conversation

sbvegan
Copy link
Collaborator

@sbvegan sbvegan commented Nov 7, 2024

@sbvegan sbvegan requested a review from a team as a code owner November 7, 2024 00:27
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 0b30cf1
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/672c0991a148cf00087bc921
😎 Deploy Preview https://deploy-preview-1081--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Nov 7, 2024

Walkthrough

This pull request involves the removal of documentation and metadata related to "cex-wallet-developers" from the project. Specifically, it deletes the cex-wallet-developers.mdx file and its associated metadata files, as well as the key-value pair for "cex-wallet-developers" in the _meta.json file. Additionally, it updates the _redirects file to redirect users from the deleted paths to the application developer overview section.

Changes

File(s) Change Summary
pages/builders/_meta.json Removed key-value pair for "cex-wallet-developers".
pages/builders/cex-wallet-developers.mdx Deleted file containing documentation for Cex Wallet Developers.
pages/builders/cex-wallet-developers/_meta.json Deleted metadata file for Cex wallet support guides.
pages/builders/cex-wallet-developers/cex-support.mdx Deleted file providing a guide on supporting OP Mainnet in exchanges.
pages/builders/cex-wallet-developers/wallet-support.mdx Deleted file providing a guide on supporting OP Mainnet in wallets.
public/_redirects Updated redirect paths for deleted Cex wallet developer resources.

Assessment against linked issues

Objective Addressed Explanation
Delete the page (related to wallet-support) (#1080)
Update the meta.json (related to wallet-support) (#1080)
Add redirect to the application developer overview (related to wallet-support) (#1080)
Delete the page (related to cex-support) (#1079)
Update the meta.json (related to cex-support) (#1079)
Add redirect to the application developer overview (related to cex-support) (#1079)

Possibly related PRs

  • removing fp and granite notices #1040: This PR involves the removal of outdated notice pages related to "fp" and "granite," which aligns with the main PR's changes that also involve the removal of metadata and documentation related to "cex-wallet-developers."
  • removing duplicate sdk notice page #976: This PR removes a duplicate SDK notice page, which is relevant as it also deals with the removal of outdated documentation, similar to the main PR's removal of the "cex-wallet-developers" documentation and metadata.
  • removing issue templates #937: This PR involves the removal of issue templates, which, while not directly related to the main PR's content, shares a common theme of cleaning up and removing unnecessary or outdated documentation elements.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 442f4c6 and 0b30cf1.

📒 Files selected for processing (6)
  • pages/builders/_meta.json (0 hunks)
  • pages/builders/cex-wallet-developers.mdx (0 hunks)
  • pages/builders/cex-wallet-developers/_meta.json (0 hunks)
  • pages/builders/cex-wallet-developers/cex-support.mdx (0 hunks)
  • pages/builders/cex-wallet-developers/wallet-support.mdx (0 hunks)
  • public/_redirects (1 hunks)
💤 Files with no reviewable changes (5)
  • pages/builders/_meta.json
  • pages/builders/cex-wallet-developers.mdx
  • pages/builders/cex-wallet-developers/_meta.json
  • pages/builders/cex-wallet-developers/cex-support.mdx
  • pages/builders/cex-wallet-developers/wallet-support.mdx
🔇 Additional comments (1)
public/_redirects (1)

108-110: LGTM! Redirects properly handle the removal of CEX & Wallet section.

The new redirects ensure users are properly directed to the application developer overview when accessing the removed CEX and wallet documentation. This aligns with the PR objectives of consolidating general application developer advice into the application section.

@sbvegan sbvegan merged commit 7e4fc90 into main Nov 7, 2024
8 of 9 checks passed
@sbvegan sbvegan deleted the sb-remove-wallets-cex-section branch November 7, 2024 00:40
This was referenced Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2024 Q4 Audit] /builders/cex-wallet-developers/wallet-support [2024 Q4 Audit] builders/cex-wallet-developers/cex-support
2 participants