Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spelling and Grammar Issues in Tutorial Suggestion Template #1101

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

donatik27
Copy link
Contributor

Short Description of Changes:

  • Corrected "copywrited" to "copyrighted" for proper spelling.
  • Changed "contain" to "does not contain" for improved grammatical structure.
  • Fixed the possessive form from "someones" to "someone's" for accuracy.
  • Added "the" in "by following the tutorial" for grammatical correctness.

Short Description of Changes:
- Corrected grammatical errors in descriptions.
- Fixed spelling of "copyrighted".
- Corrected possessive form from "someones" to "someone's".
@donatik27 donatik27 requested a review from a team as a code owner November 10, 2024 12:12
Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 0854328
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/6730a31caf477900086939b5
😎 Deploy Preview https://deploy-preview-1101--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Nov 10, 2024

Walkthrough

The pull request introduces textual corrections and clarifications to two GitHub issue templates: "Suggest a glossary term" and "Suggest a tutorial." Changes include grammatical improvements and adjustments for clarity in field descriptions and labels. Specifically, phrases were modified for better understanding, and spelling errors were corrected. These alterations do not affect the functionality or structure of the templates.

Changes

File Path Change Summary
.github/ISSUE_TEMPLATE/suggest_glossary_term.yaml Updated phrases for clarity and corrected spelling errors in field labels and descriptions.
.github/ISSUE_TEMPLATE/suggest_tutorial.yaml Minor grammatical correction in the tutorial description field for improved clarity.

Possibly related PRs

  • Docs improvements #776: This PR involves minor adjustments in wording for clarity across various documentation files, similar to the textual corrections made in the main PR's YAML configuration.
  • Fix docs #797: This PR addresses typographical errors in documentation, aligning with the main PR's focus on improving clarity through textual corrections.
  • Corrected rude grammar errors in docs #1055: This PR corrects grammar errors in documentation, which is directly related to the main PR's aim of enhancing clarity and correctness in the issue template.
  • update audit issue template #1068: This PR updates a documentation template to enhance clarity and organization, which parallels the main PR's modifications aimed at improving the issue template's clarity.

Suggested reviewers

  • sbvegan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
.github/ISSUE_TEMPLATE/suggest_glossary_term.yaml (1)

50-50: LGTM! Consider additional clarity improvements.

The change from "someones" to "someone's" correctly fixes the possessive form.

Consider rephrasing to be more direct:

-      description: If appropriate/available, please suggest an internal optimism.io link that would expand someone's learning of this term
+      description: If available, suggest an internal optimism.io link that helps explain this term in more detail
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 72a4abc and 0854328.

📒 Files selected for processing (2)
  • .github/ISSUE_TEMPLATE/suggest_glossary_term.yaml (2 hunks)
  • .github/ISSUE_TEMPLATE/suggest_tutorial.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/ISSUE_TEMPLATE/suggest_tutorial.yaml
🔇 Additional comments (2)
.github/ISSUE_TEMPLATE/suggest_glossary_term.yaml (2)

21-21: LGTM! Grammar improvement enhances clarity.

The change from "or contain" to "and does not contain" improves parallelism and makes the requirement more explicit.


42-42: LGTM! Correct spelling of legal term.

The change from "copywrited" to "copyrighted" fixes the spelling and uses the proper legal terminology.

@krofax krofax merged commit a942c57 into ethereum-optimism:main Nov 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants