fix variable name $PRIVATE_KEY #1164
Conversation
before this fix, the script revered to the private key in variable named $PRIVATE_KEY. This made the snippet to not work is following the whole tutorial at https://docs.optimism.io/builders/app-developers/tutorials/cross-dom-bridge-erc20 where private key is declared under a different name This change updates the variable name so the tutorial can work end to end by copy-pasting code snippets fixes ethereum-optimism#1163
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces a modification in the script located at Assessment against linked issues
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)pages/builders/app-developers/tutorials/standard-bridge-standard-token.mdx (1)Pattern
🔇 Additional comments (1)pages/builders/app-developers/tutorials/standard-bridge-standard-token.mdx (1)
The change from Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
public/tutorials/standard-bridge-standard-token.sh (1)
6-6: Consider adding a comment explaining the command's purpose.The
cast sendcommand performs a critical operation (creating an Optimism Mintable ERC20 token), but its purpose isn't immediately clear from the code. Consider adding a comment explaining what this command does and what the output represents.+# Create an Optimism Mintable ERC20 token and extract the deployed token address from the logs cast send 0x4200000000000000000000000000000000000012 "createOptimismMintableERC20(address,string,string)" $TUTORIAL_L1_ERC20_ADDRESS "My Standard Demo Token" "L2TKN" --private-key $TUTORIAL_PRIVATE_KEY --rpc-url $TUTORIAL_RPC_URL --json | jq -r '.logs[0].topics[2]' | cast parse-bytes32-address
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
public/tutorials/standard-bridge-standard-token.sh(1 hunks)
🔇 Additional comments (1)
public/tutorials/standard-bridge-standard-token.sh (1)
6-6: LGTM! Variable name now matches tutorial declaration.
The change from $PRIVATE_KEY to $TUTORIAL_PRIVATE_KEY correctly aligns with the variable declared at the beginning of the tutorial, fixing the inconsistency reported in issue #1163.
updates the hash related to standard-bridge-standard-token.sh following change for ethereum-optimism#1163
Description
Before this fix, the script referred to the private key in variable named $PRIVATE_KEY while it's declared as $TUTORIAL_PRIVATE_KEY at the beginning of the tutorial.
Hence, the code snippet won't work for someone following the whole tutorial from beginning to end.
This change replaces the variable in the snippet to be $TUTORIAL_PRIVATE_KEY so it can be copy-pasted and work.
Additional context
Metadata