-
Notifications
You must be signed in to change notification settings - Fork 265
Suggested Docs fixes #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested Docs fixes #1251
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request involves minor documentation updates across several Markdown files in the OP Stack documentation. The changes primarily focus on grammatical improvements, textual clarifications, and minor restructuring of content. Specifically, the modifications include correcting grammatical errors, adjusting terminology, clarifying technical descriptions, and reordering documentation components. The updates span four different documentation pages: Sequence Diagram(s)(No sequence diagram is necessary for these documentation changes) Possibly related issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/stack/smart-contracts.mdx (1)
82-82
: Add hyphen in compound adjective.When "1 week" is used as a compound adjective before "exit window", it should be hyphenated.
-closer to satisfying the 1 week exit window requirement for Stage 1. +closer to satisfying the 1-week exit window requirement for Stage 1.🧰 Tools
🪛 LanguageTool
[uncategorized] ~82-~82: When a number forms part of an adjectival compound, use a hyphen.
Context: ...he Superchain closer to satisfying the 1 week exit window requirement for Stage 1. ...(MISSING_HYPHEN)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
pages/stack/differences.mdx
(2 hunks)pages/stack/interop/assets.mdx
(1 hunks)pages/stack/interop/op-supervisor.mdx
(2 hunks)pages/stack/smart-contracts.mdx
(3 hunks)
✅ Files skipped from review due to trivial changes (3)
- pages/stack/interop/assets.mdx
- pages/stack/interop/op-supervisor.mdx
- pages/stack/differences.mdx
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/smart-contracts.mdx (1)
Pattern **/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
🪛 LanguageTool
pages/stack/smart-contracts.mdx
[uncategorized] ~82-~82: When a number forms part of an adjectival compound, use a hyphen.
Context: ...he Superchain closer to satisfying the 1 week exit window requirement for Stage 1. ...
(MISSING_HYPHEN)
🔇 Additional comments (2)
pages/stack/smart-contracts.mdx (2)
358-358
: LGTM! Grammar fix.The removal of the redundant "is" improves the sentence clarity.
402-402
: LGTM! Clear and concise description.The description accurately explains the purpose of the PreimageOracle contract.
Description
This pull request addresses various content updates and fixes across multiple pages in the OP Stack documentation:
differences.mdx
:PREVRANDAO
for accuracy. It now states:"Returns the PREVRANDAO (the most recent RANDAO) value of L1 at the current L1 origin block."
assets.mdx
:op-supervisor.mdx
:smart-contracts.mdx
:PreimageOracle
contract: "is used for storing permissioned pre-images."Tests
No tests are required for this PR as it consists of documentation updates. The changes were reviewed to ensure proper grammar, accuracy, and consistency across files.
Additional context
These updates enhance the clarity and usability of the documentation for developers using the OP Stack.