Skip to content

chore: update preinstalls #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore: update preinstalls #1303

merged 1 commit into from
Jan 30, 2025

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Jan 30, 2025

Preinstall docs were out of date, h/t @pcaversaccio for flagging

@mds1 mds1 requested a review from a team as a code owner January 30, 2025 00:31
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit e6c4436
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/679ac84877899d00088ec804
😎 Deploy Preview https://deploy-preview-1303--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

📝 Walkthrough

Walkthrough

The pull request modifies the documentation for preinstalled contracts in the Optimism ecosystem. The changes involve removing several existing contracts like Multicall3, create2 Proxy, create2deployer, and permit2 from the preinstalls table. In their place, new contracts are added, including CreateX, multiple versions of ERC-4337 contracts (EntryPoint and SenderCreator for versions 0.6.0 and 0.7.0), and updating the associated contract addresses. The documentation update reflects the current set of preinstalled contracts for new OP Chains, ensuring the information is up-to-date and accurate.

Possibly related issues

Possibly related PRs

Suggested reviewers

  • sbvegan

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
pages/builders/chain-operators/features/preinstalls.mdx (1)

Line range hint 8-13: Improve documentation style and consistency.

Please revise the introductory paragraphs to align with our documentation guidelines:

  1. Replace personal pronouns with proper nouns
  2. Ensure consistent capitalization of technical terms
  3. Use the Oxford comma consistently

Apply these changes:

-To go to production on a new chain, developers need their core contracts: Gnosis Safes, the 4337 entrypoint, create2deployer, etc. On a blank EVM, these contracts can take weeks to be deployed. Now, core contracts come *preinstalled* on the OP Stack -- no third party deployment necessary.
-Whether hacking alone or starting the next big rollup, developers can start using their favorite contracts as soon as they spin up their chain.
+To go to production on a new chain, the system requires core contracts: Gnosis Safe, the ERC-4337 EntryPoint, Create2Deployer, and other essential contracts. On a blank EVM, contract deployment can take weeks. The OP Stack provides these core contracts preinstalled, eliminating the need for third-party deployment.
+The preinstalled contracts are available immediately upon chain initialization, enabling rapid development and deployment.
🧹 Nitpick comments (1)
pages/builders/chain-operators/features/preinstalls.mdx (1)

43-43: Update the resources section formatting.

The resources section needs formatting adjustments to align with our documentation guidelines:

  1. Remove italics used for emphasis
  2. Use proper title case for the link text

Apply this change:

-*   Still Have Questions? You can reach us in our [developer support forum](https://github.com/ethereum-optimism/developers/discussions).
+*   Still have questions? Visit the [Developer Support Forum](https://github.com/ethereum-optimism/developers/discussions).
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e7fb64 and e6c4436.

📒 Files selected for processing (1)
  • pages/builders/chain-operators/features/preinstalls.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/chain-operators/features/preinstalls.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (1)
pages/builders/chain-operators/features/preinstalls.mdx (1)

33-41: LGTM! The contract table updates are accurate and well-formatted.

The updated table entries maintain consistency in formatting while providing accurate contract references and addresses.

@cpengilly cpengilly merged commit db5b6a8 into main Jan 30, 2025
8 checks passed
@cpengilly cpengilly deleted the update-preinstalls branch January 30, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants