-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enhance CONTRIBUTING.md with comprehensive technical details and improved structure #1331
base: main
Are you sure you want to change the base?
Conversation
crStiv
commented
Feb 7, 2025
- Restore technical details about Nextra framework
- Add build troubleshooting guide
- Improve content guidelines section
- Maintain clear structure and navigation
- Keep all critical information
- Enhance readability with better formatting
👷 Deploy request for docs-optimism pending review.Visit the deploys page to approve it
|
📝 WalkthroughWalkthroughThe pull request restructures the CONTRIBUTING.md file for Optimism Docs by introducing a comprehensive Table of Contents and clearly defined sections. The document now includes parts such as Overview, Getting Started, Contributing Process, Pull Request Process, Code of Conduct, and Additional Ways to Contribute. The reorganization condenses and reformats the previous content, adding detailed instructions on prerequisites, development setup, file architecture, local testing, and pull request submission. The process for submitting pull requests has been reworked into a structured multi-step guide, emphasizing the importance of passing local tests and resolving issues prior to submission. Additionally, warnings and notes have been reformulated for improved visibility, and a Code of Conduct section has been added to outline expected contributor behavior. Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CONTRIBUTING.md (2)
97-99
: Review Blockquote Formatting
The blockquoted notes (for “Note”, “Important”, and “Tip”) are clear and useful. Static analysis hints indicate potential blank lines within these blockquote sections (MD028). Please confirm that no unintended blank lines are present inside these blockquotes to comply with markdownlint guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
98-98: Blank line inside blockquote
null(MD028, no-blanks-blockquote)
125-125
: Punctuation Consistency at Conclusion
The final thank-you line ("Thank you for contributing to Optimism Docs! 🎉") might benefit from a slight punctuation adjustment to ensure a smooth transition from the preceding list. For example, if the list item “- 🗣️ Spreading the word in your community” is intended to flow into the closing sentence, consider adding a comma or ensuring a clear paragraph break for improved readability.🧰 Tools
🪛 LanguageTool
[uncategorized] ~125-~125: Possible missing comma found.
Context: ...ommunity Thank you for contributing to Optimism Docs! 🎉(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CONTRIBUTING.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md
[uncategorized] ~125-~125: Possible missing comma found.
Context: ...ommunity Thank you for contributing to Optimism Docs! 🎉
(AI_HYDRA_LEO_MISSING_COMMA)
🪛 markdownlint-cli2 (0.17.2)
CONTRIBUTING.md
98-98: Blank line inside blockquote
null
(MD028, no-blanks-blockquote)
100-100: Blank line inside blockquote
null
(MD028, no-blanks-blockquote)
🔇 Additional comments (1)
CONTRIBUTING.md (1)
5-19
: Well-Structured Table of Contents
The new Table of Contents provides a clear and comprehensive roadmap for navigating the document. Please verify that each anchor link (e.g. “#overview”, “#getting-started”, etc.) exactly matches the corresponding section headers in the file to ensure smooth in-page navigation.