-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update oracles.mdx #768
Update oracles.mdx #768
Conversation
cpengilly
commented
Jun 25, 2024
- added RNG section
- added RNG info to providers that support it
- added 2 providers: API3 and Chronicle
- added RNG section - added RNG info to providers that support it - added 2 providers: API3 and Chronicle
WalkthroughRecent updates include expanding the oracles documentation with new sections on random number generation and various oracles. Specific terminology in Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files not reviewed due to errors (1)
Additional context usedPath-based instructions (1)
LanguageTool
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (5)
pages/builders/tools/build/oracles.mdx (5)
Line range hint
23-23
: Consider adding a comma for clarity.The sentence could be improved for readability by adding a comma after "Usually":
- Usually they are either run by the organization... + Usually, they are either run by the organization...
Line range hint
30-30
: Hyphenation correction in "up-to-date".The phrase "up to date" should be hyphenated when used as an adjective before a noun:
- always have up to date information available onchain. + always have up-to-date information available onchain.
Line range hint
100-100
: Grammar correction: "as well as" usage.The phrase "as well as" should be preceded by "and" when used in this context:
- both the real-time spot price of the asset as well as an accompanying confidence interval band... + both the real-time spot price of the asset and an accompanying confidence interval band...
Line range hint
115-115
: Grammar correction: Missing determiner.The phrase "highest update frequency" should have a determiner before "highest":
- specifically for Perps and Options, highest update frequency and front-running protection. + specifically for Perps and Options, the highest update frequency and front-running protection.
Line range hint
125-125
: Hyphenation in compound modifiers.The hyphenation in "highly-rated" is unnecessary since the adverb ends in 'ly':
- highly-rated by community + highly rated by community
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
words.txt (1)
Line range hint
22-22
: Term replacement: Chainlink's to chainlistThis change might be a mistake unless "chainlist" is a new terminology or concept introduced in the project. If "Chainlink's" was intended, this needs correction.
- chainlist + Chainlink'sTools
LanguageTool
[duplication] ~28-~28: Möglicher Tippfehler: ein Wort wird wiederholt (GERMAN_WORD_REPEAT_RULE)
Context: ...blobpool blobspace blockhash blocklists BLOCKLOGS blocklogs BLOCKPROFILERATE blockprofilerate Block...
[duplication] ~30-~30: Möglicher Tippfehler: ein Wort wird wiederholt (GERMAN_WORD_REPEAT_RULE)
Context: ...lockhash blocklists BLOCKLOGS blocklogs BLOCKPROFILERATE blockprofilerate Blockscout blocktime BLOOMFILTER bloomf...