-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Old wip callout to the new callout #775
Conversation
WalkthroughThis update primarily focuses on removing maintenance warnings and error callouts from multiple tutorial pages and replacing them with a consistent "work-in-progress" message through a new Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (12)
Files not reviewed due to errors (2)
Additional context usedPath-based instructions (11)
LanguageTool
Gitleaks
Additional comments not posted (12)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
Outside diff range and nitpick comments (6)
pages/builders/app-developers/tutorials/send-tx-from-eth.mdx (3)
Line range hint
23-23
: Grammar Improvement Suggested.Consider adding a comma after "tutorial" to improve the flow of the sentence.
- In this tutorial you'll learn how to trigger a transaction on OP Mainnet from Ethereum. + In this tutorial, you'll learn how to trigger a transaction on OP Mainnet from Ethereum.
Line range hint
88-88
: Consider simplifying the sentence.The phrase "in order to" could be simplified to "to" for conciseness.
- You need a private key in order to sign transactions. + You need a private key to sign transactions.
Line range hint
170-170
: Grammar Improvement Suggested.Consider adding a comma after "contract" for better readability.
- When sending transactions via the `OptimismPortal` contract it's important to always include a gas buffer. + When sending transactions via the `OptimismPortal` contract, it's important to always include a gas buffer.pages/builders/app-developers/tutorials/sdk-estimate-costs.mdx (2)
Line range hint
69-69
: Consider simplifying the sentence.The phrase "in order to" could be simplified to "to" for conciseness.
- You will need to get some ETH on OP Sepolia in order to run the code in this tutorial. + You will need to get some ETH on OP Sepolia to run the code in this tutorial.
Line range hint
77-77
: Consider simplifying the sentence.The phrase "in order to" could be simplified to "to" for conciseness.
- You need a private key in order to sign transactions. + You need a private key to sign transactions.pages/builders/app-developers/tutorials/sdk-trace-txns.mdx (1)
Line range hint
183-183
: Grammar Improvement Suggested.Consider changing "amount of tokens" to "number of tokens" for grammatical accuracy.
- ...arch for `Mint` events to determine the amount of tokens that were minted as a result... + ...arch for `Mint` events to determine the number of tokens that were minted as a result...
Description
Replaced the old callout for the new ones
Before
After (and it sticks to the top when scrolling aswell)
Let me know if you want both callouts to be there or just one callout