-
Notifications
You must be signed in to change notification settings - Fork 265
Update genesis.mdx #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update genesis.mdx #791
Conversation
WalkthroughThe updated guide provides clearer instructions for creating L2 genesis files. It now details the generation of Changes
Possibly related issues
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (2)
pages/builders/chain-operators/deploy/genesis.mdx (2)
89-90
: Enhance external link descriptions.The links to initialization instructions could be more descriptive to provide better context on what the user will learn or achieve by following them.
65-75
: Update the command example to reflect recent changes.The command example in
pages/builders/chain-operators/deploy/genesis.mdx
still references versionv1.7.6
and uses the placeholderPath to L2 genesis state dump
. Please update it to reflect the recent changes and correct paths.
pages/builders/chain-operators/deploy/genesis.mdx
: Lines 65-75Analysis chain
Update the command example to reflect recent changes.
Ensure that the command example reflects the recent changes and updates mentioned in the PR description. This includes the correct version numbers and paths.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the command example reflects recent changes. # Test: Check if the command includes the latest version and correct paths. grep 'v1.7.6' genesis.mdx grep 'Path to L2 genesis state dump' genesis.mdxLength of output: 166
Script:
#!/bin/bash # Step 1: Search for the file `genesis.mdx` in the repository. file_path=$(fd genesis.mdx) # Step 2: Verify the command example reflects recent changes using the correct file path. if [ -n "$file_path" ]; then grep 'v1.7.6' "$file_path" grep 'Path to L2 genesis state dump' "$file_path" else echo "File genesis.mdx not found." fiLength of output: 427
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks George!
Co-authored-by: soyboy <85043086+sbvegan@users.noreply.github.com>
I was following these instructions today and they didn't look quite right to me. With these changes, I was successful in getting the commands to run (whereas before I was not).