Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block numbers of network upgrades #912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fvictorio
Copy link

The network upgrades table is very useful but sometimes you want to know the exact block number at which an ugprade was activated. I added these numbers in the table, following a methodology I'll explain below. I'd recommend someone triple-checks them with some other approach (I guess this information must be somewhere else?).

My approach to get the block numbers was mainly taking the timestamp and using etherscan "Timestamp to Block" feature (op mainnet, op sepolia) to get the block number.

Then, for all upgrades except Delta and Granite, I ran a separate check to confim this was the right block number:

  • For Canyon, I checked that PUSH0 was available in that block, but not in the previous one
  • For Ecotone, I checked that TLOAD was available in that block, but not in the previous one
  • For Fjord, I checked that calling isFjord() in GasPriceOracle returned true in that block, and reverted in the previous one.

Delta doesn't seem to have any way to check its activation using only the JSON-RPC layer, so I just used the result of Etherscan, with one caveat: for mainnet, the value I got was 116480611, but all the other mainnet blocks I got ended in 12, so I used 116480612, since it's too much of a coincidence (and the timestamp-to-block tool can have off-by-one errors).

For Granite I guess I could check if the bn256Pairing precompile has the additional validation, but that seems more work than I can put into this today 😅

Also: the timestamp of the Fjord upgrade for OP Sepolia seems wrong. It had a different date than mainnet, but the UNIX timestamp was the same. I guess it was a copy-paste error.

@fvictorio fvictorio requested a review from a team as a code owner September 20, 2024 11:43
Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Walkthrough

The changes involve updates to the network upgrades documentation, specifically enhancing the table that lists various upgrades by adding block numbers to their activation timestamps for both the OP Mainnet and OP Sepolia. This includes upgrades such as Granite, Fjord, Ecotone, Delta, and Canyon, while maintaining the existing governance approval links. The timestamp format has been slightly adjusted to include the block number.

Changes

File Path Change Summary
pages/builders/node-operators/network-upgrades.mdx Added block numbers to activation timestamps for network upgrades; modified timestamp format.

Possibly related issues

Possibly related PRs


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 946f883 and 86b86c3.

Files selected for processing (1)
  • pages/builders/node-operators/network-upgrades.mdx (1 hunks)
Additional context used
Path-based instructions (1)
pages/builders/node-operators/network-upgrades.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Use bold for prominence instead of all caps or italics.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
    "
Additional comments not posted (4)
pages/builders/node-operators/network-upgrades.mdx (4)

26-27: LGTM!

The Granite upgrade details have been added correctly, including the governance approval link, activation timestamps, and block numbers for both OP Mainnet and OP Sepolia. The format is consistent with the other rows in the table.


27-28: Verify the OP Sepolia activation timestamp for Fjord.

The Fjord upgrade details have been added correctly, including the governance approval link, activation timestamps, and block numbers for both networks. The format is consistent with the other rows.

However, as mentioned in the PR summary, there might be a discrepancy between the date and the UNIX timestamp for the Fjord upgrade on OP Sepolia. Please double-check the timestamp 1716998400 and ensure it corresponds to the correct date and time.


28-29: LGTM!

The Ecotone upgrade details have been added correctly, including the governance approval link, activation timestamps, and block numbers for both OP Mainnet and OP Sepolia. The format is consistent with the other rows in the table.


29-30: Verify the OP Mainnet block number adjustment for Delta.

The Delta upgrade details have been added correctly, including the governance approval link, activation timestamps, and block numbers for both networks. The format is consistent with the other rows.

However, as mentioned in the PR summary, the OP Mainnet block number was adjusted from 116480611 to 116480612 based on a pattern observed in other mainnet blocks. Since this could not be definitively verified through the JSON-RPC layer, please double-check the accuracy of this adjustment and provide additional context or evidence to support the change.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 86b86c3
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/66ed5fc7013e5400087a3922
😎 Deploy Preview https://deploy-preview-912--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant