Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTU Coin to standard bridge for lisk and lisk-sepolia. #984

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

databu
Copy link

@databu databu commented Nov 10, 2024

Description

Add UTU Coin to standard bridge for lisk and lisk-sepolia as described in the README.

Tests

None, the process for adding tokens doesn't require adding tests.

Additional context

None.

Metadata

None.

@databu databu requested review from wbnns and a team as code owners November 10, 2024 13:12
@databu
Copy link
Author

databu commented Nov 10, 2024

The README says to add the lisk label and @shuse2 as a reviewer but I don't seem to be able to do that.

@shuse2 shuse2 self-requested a review November 11, 2024 09:29
@ricott1
Copy link
Contributor

ricott1 commented Nov 11, 2024

Hello, can you please run the suggested tests for both Lisk and Lisk-Sepolia?

npx tsx ./bin/cli.ts validate --datadir ./data --tokens UTU

@ricott1
Copy link
Contributor

ricott1 commented Nov 26, 2024

Hello @databu, can you take a look at my previous comment? The tests are failing when executing npx tsx ./bin/cli.ts validate --datadir ./data --tokens UTU:

[ 'UTU' ]
error: UTU on chain lisk token 0x5dc70C31cc67867c1DB8E697E3D9a680f77f0924 not using standard bridge
error: UTU on chain lisk-sepolia token 0x05f47FDe56DfBA3E3692445c9b9C17B2128c1531 not using standard bridge
warning: UTU on chain sepolia token 0xC3586558ddb1Cc6C7c5338691842b8d5F47D253d has overridden symbol
warning: UTU on chain sepolia token 0xC3586558ddb1Cc6C7c5338691842b8d5F47D253d has overridden name
warning: UTU on chain lisk-sepolia token 0x05f47FDe56DfBA3E3692445c9b9C17B2128c1531 has overridden symbol
warning: UTU on chain lisk-sepolia token 0x05f47FDe56DfBA3E3692445c9b9C17B2128c1531 has overridden name

Please address the errors so we can approve the PR

@databu
Copy link
Author

databu commented Nov 26, 2024

Oh right, I hope I get around to this this Friday.

@databu
Copy link
Author

databu commented Nov 29, 2024

When deploying the bridged token, I copied addresses from the LISK docs and might have gotten mixed up. The Sepolia version has BRIDGE=0x4200000000000000000000000000000000000007 which I seem to have copied from here. while the mainnet token has BRIDGE=0x4200000000000000000000000000000000000012 which I seem to have copied from here.

I'm not sure why I copied from these places, but I also can't seem to find the actual standard bridge addresses in the docs. Please link the doc where I can find them, then I'll re-deploy the bridged tokens and update the PR with the new token addresses.

@wbnns wbnns added the lisk label Nov 29, 2024
@matjazv
Copy link

matjazv commented Dec 3, 2024

When deploying the bridged token, I copied addresses from the LISK docs and might have gotten mixed up. The Sepolia version has BRIDGE=0x4200000000000000000000000000000000000007 which I seem to have copied from here. while the mainnet token has BRIDGE=0x4200000000000000000000000000000000000012 which I seem to have copied from here.

I'm not sure why I copied from these places, but I also can't seem to find the actual standard bridge addresses in the docs. Please link the doc where I can find them, then I'll re-deploy the bridged tokens and update the PR with the new token addresses.

In below link you may find L2StandardBridge address, which is in both cases (Lisk Mainnet and Lisk Sepolia) the same (0x4200000000000000000000000000000000000010).
https://docs.lisk.com/contracts#predeploys-on-lisk

@databu
Copy link
Author

databu commented Dec 14, 2024

Thanks, will re-deploy using this address, then follow up. However I think the link to that page and/or the standard bridge address itself, should be included in the docs for deploying tokens using the standard bridge, and the examples with the other addresses should be removed...

@databu
Copy link
Author

databu commented Dec 14, 2024

I've re-deployed the contracts using the standard bridge address of 0x4200000000000000000000000000000000000010, as given above, and updated data/UTU/data.json accordingly.

I've also tried to run npm install in order to run the validation myself, but get errors:

goldmund:ethereum-optimism.github.io babarr$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @eth-optimism/tokenlist@10.0.162
npm ERR! Found: eslint@8.57.1
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^8.16.0" from the root project
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@5.62.0
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev @typescript-eslint/eslint-plugin@"^5.26.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^5.0.0 || ^6.0.0 || ^7.0.0" from @typescript-eslint/parser@4.33.0
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"^4.26.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/babarr/.npm/_logs/2024-12-14T12_42_52_359Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/babarr/.npm/_logs/2024-12-14T12_42_52_359Z-debug-0.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants