simulator (op): add l2 genesis predeploy, restore all rpc tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
approved these changes
May 11, 2022
protolambda
pushed a commit
that referenced
this pull request
Jul 27, 2022
* simulators (op): restore predeploy * simulators (op): restore all rpc tests * simulators (op): log - include tx hash in error
mslipper
pushed a commit
that referenced
this pull request
Sep 8, 2022
* simulators (op): restore predeploy * simulators (op): restore all rpc tests * simulators (op): log - include tx hash in error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores all of the RPC tests copied from
ethereum/rpcsimulator. This is an alternative approach to increasing RPC coverage, in contrast to #4, where we were deploying the contract and using it instead of a predeployed contract.The tests are exactly same as
ethereum/rpc, so the predeploy vault contract and test contract have also been copied over. It was relatively easier to add the predeploy to L2 genesis, instead of adding a new setup step that does the contract deployment.With this PR all the existing rpc tests except 5 test which depend on predeploy
TransactionByHash/TransactionInBlockare failing due to:panic: deposit tx does not have signaturewhich seems to be an issue with the reference optimistic geth failing to parse a predeployed transaction. A bug report will be filed on that but in the meantime, this test suite is working as intended so it should be merged.
Some tests are a bit flaky because of timing issues around transaction inclusion. This will be fixed in the next round of PRs.