-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Audit/dapphub b02 gas relaying check (#85)
* add SafeMath, add dummy check for gas sufficiency * gas_overhead const * custom safemath * add gasLimit param for testing, safemath credit
- Loading branch information
Showing
3 changed files
with
218 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
167 changes: 167 additions & 0 deletions
167
packages/contracts/contracts/optimistic-ethereum/libraries/wrappers/Lib_SafeMathWrapper.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| // Pulled from @openzeppelin/contracts/math/SafeMath.sol | ||
| pragma solidity ^0.7.0; | ||
|
|
||
| /* Library Imports */ | ||
| import { Lib_SafeExecutionManagerWrapper } from "./Lib_SafeExecutionManagerWrapper.sol"; | ||
|
|
||
| /** | ||
| * @title Lib_SafeMathWrapper | ||
| */ | ||
|
|
||
| /** | ||
| * @dev Wrappers over Solidity's arithmetic operations with added overflow | ||
| * checks. | ||
| * | ||
| * Arithmetic operations in Solidity wrap on overflow. This can easily result | ||
| * in bugs, because programmers usually assume that an overflow raises an | ||
| * error, which is the standard behavior in high level programming languages. | ||
| * `SafeMath` restores this intuition by reverting the transaction when an | ||
| * operation overflows. | ||
| * | ||
| * Using this library instead of the unchecked operations eliminates an entire | ||
| * class of bugs, so it's recommended to use it always. | ||
| */ | ||
|
|
||
| library Lib_SafeMathWrapper { | ||
| /** | ||
| * @dev Returns the addition of two unsigned integers, reverting on | ||
| * overflow. | ||
| * | ||
| * Counterpart to Solidity's `+` operator. | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - Addition cannot overflow. | ||
| */ | ||
| function add(uint256 a, uint256 b) internal returns (uint256) { | ||
| uint256 c = a + b; | ||
| Lib_SafeExecutionManagerWrapper.safeREQUIRE(c >= a, "Lib_SafeMathWrapper: addition overflow"); | ||
|
|
||
| return c; | ||
| } | ||
|
|
||
| /** | ||
| * @dev Returns the subtraction of two unsigned integers, reverting on | ||
| * overflow (when the result is negative). | ||
| * | ||
| * Counterpart to Solidity's `-` operator. | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - Subtraction cannot overflow. | ||
| */ | ||
| function sub(uint256 a, uint256 b) internal returns (uint256) { | ||
| return sub(a, b, "Lib_SafeMathWrapper: subtraction overflow"); | ||
| } | ||
|
|
||
| /** | ||
| * @dev Returns the subtraction of two unsigned integers, reverting with custom message on | ||
| * overflow (when the result is negative). | ||
| * | ||
| * Counterpart to Solidity's `-` operator. | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - Subtraction cannot overflow. | ||
| */ | ||
| function sub(uint256 a, uint256 b, string memory errorMessage) internal returns (uint256) { | ||
| Lib_SafeExecutionManagerWrapper.safeREQUIRE(b <= a, errorMessage); | ||
| uint256 c = a - b; | ||
|
|
||
| return c; | ||
| } | ||
|
|
||
| /** | ||
| * @dev Returns the multiplication of two unsigned integers, reverting on | ||
| * overflow. | ||
| * | ||
| * Counterpart to Solidity's `*` operator. | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - Multiplication cannot overflow. | ||
| */ | ||
| function mul(uint256 a, uint256 b) internal returns (uint256) { | ||
| // Gas optimization: this is cheaper than requiring 'a' not being zero, but the | ||
| // benefit is lost if 'b' is also tested. | ||
| // See: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/522 | ||
| if (a == 0) { | ||
| return 0; | ||
| } | ||
|
|
||
| uint256 c = a * b; | ||
| Lib_SafeExecutionManagerWrapper.safeREQUIRE(c / a == b, "Lib_SafeMathWrapper: multiplication overflow"); | ||
|
|
||
| return c; | ||
| } | ||
|
|
||
| /** | ||
| * @dev Returns the integer division of two unsigned integers. Reverts on | ||
| * division by zero. The result is rounded towards zero. | ||
| * | ||
| * Counterpart to Solidity's `/` operator. Note: this function uses a | ||
| * `revert` opcode (which leaves remaining gas untouched) while Solidity | ||
| * uses an invalid opcode to revert (consuming all remaining gas). | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - The divisor cannot be zero. | ||
| */ | ||
| function div(uint256 a, uint256 b) internal returns (uint256) { | ||
| return div(a, b, "Lib_SafeMathWrapper: division by zero"); | ||
| } | ||
|
|
||
| /** | ||
| * @dev Returns the integer division of two unsigned integers. Reverts with custom message on | ||
| * division by zero. The result is rounded towards zero. | ||
| * | ||
| * Counterpart to Solidity's `/` operator. Note: this function uses a | ||
| * `revert` opcode (which leaves remaining gas untouched) while Solidity | ||
| * uses an invalid opcode to revert (consuming all remaining gas). | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - The divisor cannot be zero. | ||
| */ | ||
| function div(uint256 a, uint256 b, string memory errorMessage) internal returns (uint256) { | ||
| Lib_SafeExecutionManagerWrapper.safeREQUIRE(b > 0, errorMessage); | ||
| uint256 c = a / b; | ||
| // assert(a == b * c + a % b); // There is no case in which this doesn't hold | ||
|
|
||
| return c; | ||
| } | ||
|
|
||
| /** | ||
| * @dev Returns the remainder of dividing two unsigned integers. (unsigned integer modulo), | ||
| * Reverts when dividing by zero. | ||
| * | ||
| * Counterpart to Solidity's `%` operator. This function uses a `revert` | ||
| * opcode (which leaves remaining gas untouched) while Solidity uses an | ||
| * invalid opcode to revert (consuming all remaining gas). | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - The divisor cannot be zero. | ||
| */ | ||
| function mod(uint256 a, uint256 b) internal returns (uint256) { | ||
| return mod(a, b, "Lib_SafeMathWrapper: modulo by zero"); | ||
| } | ||
|
|
||
| /** | ||
| * @dev Returns the remainder of dividing two unsigned integers. (unsigned integer modulo), | ||
| * Reverts with custom message when dividing by zero. | ||
| * | ||
| * Counterpart to Solidity's `%` operator. This function uses a `revert` | ||
| * opcode (which leaves remaining gas untouched) while Solidity uses an | ||
| * invalid opcode to revert (consuming all remaining gas). | ||
| * | ||
| * Requirements: | ||
| * | ||
| * - The divisor cannot be zero. | ||
| */ | ||
| function mod(uint256 a, uint256 b, string memory errorMessage) internal returns (uint256) { | ||
| Lib_SafeExecutionManagerWrapper.safeREQUIRE(b != 0, errorMessage); | ||
| return a % b; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters