Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

span-batch validation test improvements #7853

Closed
protolambda opened this issue Oct 25, 2023 · 1 comment · Fixed by #7953
Closed

span-batch validation test improvements #7853

protolambda opened this issue Oct 25, 2023 · 1 comment · Fixed by #7953

Comments

@protolambda
Copy link
Contributor

protolambda commented Oct 25, 2023 •
edited
Loading

Test coverage:

  • for batch.GetTimestamp() > l2SafeHead.Time (related to below)
  • for startEpochNum > parentBlock.L1Origin.Number+1 check span-batch validation
  • for startEpochNum == parentBlock.L1Origin.Number+1 check in span-batch validation
  • for batch.GetBlockTimestamp(i) <= l2SafeHead.Time { in span batch validation
  • for if batch.GetBlockEpochNum(i) > batch.GetBlockEpochNum(i-1) { in span batch validation
  • for !bytes.Equal(safeBlockTxs[j+depositCount], batchTxs[j]) in span-batch validation

Test coverage ideas by @ajsutton
This was referenced Oct 25, 2023
Merged
Closed
@ImTei ImTei mentioned this issue Oct 31, 2023
Merged
@ImTei
Copy link
Collaborator

ImTei commented Oct 31, 2023

opened PR: #7953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Batch validation test refactoring testinprod-io/optimism
2 participants
@protolambda @ImTei