Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch validation test refactoring #7953

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Batch validation test refactoring #7953

merged 2 commits into from
Nov 1, 2023

Conversation

ImTei
Copy link
Collaborator

@ImTei ImTei commented Oct 31, 2023 •
edited by protolambda
Loading

Description
This PR includes batches_test.go refactoring and new test cases to cover #7853

  • Delete duplicated lines from batches_test.go
  • To cover missing parts raised in span-batch validation test improvements  #7853, I've implemented log-based tests to check if the code was executed as we expected.
  • Add log checks to existing span batch validation test cases
  • Add new test cases to cover missing parts

Fixes #7853

@ImTei
batches_test refactoring
249d9e7 
Support log based test for batch validation rules
Add more test cases for span batch
This was referenced Oct 31, 2023
Closed
Closed
protolambda
protolambda approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test improvements, the code-coverage checks out, and the logs check it nicely 👍

@protolambda protolambda enabled auto-merge October 31, 2023 23:01
@protolambda protolambda added this pull request to the merge queue Nov 1, 2023
Merged via the queue into ethereum-optimism:develop with commit 58c8b1f Nov 1, 2023
@protolambda protolambda deleted the tip/batches-test-refactoring branch November 1, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@trianglesphere trianglesphere Awaiting requested review from trianglesphere

@ajsutton ajsutton Awaiting requested review from ajsutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

span-batch validation test improvements
2 participants
@ImTei @protolambda