Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geth: update to v1.13.15 #10353

Merged
merged 10 commits into from
May 2, 2024
Merged

geth: update to v1.13.15 #10353

merged 10 commits into from
May 2, 2024

Conversation

axelKingsley
Copy link
Contributor

@axelKingsley axelKingsley commented Apr 30, 2024

Updates the go.mod to use op-geth based on upstream version v1.13.15

This PR is made against v1.13.14 branch because there were are required changes to support the a version (.13) which must be built on.

One additional changes required to support the new version beyond changes made in previous updates:
New:

  • use of NewStackTrie changed slightly and has been updated in the single location we use it
    Previous:
  • trie pakcage updated to triedb package
  • core types deprecated for types types

One additional change was added which is not strictly required, but enabled:

  • Removed the pin.go file which fixes a dependency to a specific version, preventing version conflicts. with a more updated geth, we no longer need the pin.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.47%. Comparing base (acd8cf8) to head (03ada72).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10353      +/-   ##
===========================================
+ Coverage    42.33%   43.47%   +1.14%     
===========================================
  Files           73       41      -32     
  Lines         4845     3986     -859     
  Branches       766      614     -152     
===========================================
- Hits          2051     1733     -318     
+ Misses        2684     2143     -541     
  Partials       110      110              
Flag Coverage Δ
cannon-go-tests 81.43% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests ?
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests ?
sdk-tests 40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

@axelKingsley axelKingsley changed the title Attempt geth v1.13.15 geth: update to v1.13.15 May 1, 2024
@axelKingsley axelKingsley marked this pull request as ready for review May 1, 2024 14:43
@axelKingsley axelKingsley requested review from a team as code owners May 1, 2024 14:43
Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

Walkthrough

The changes across various files in the Ethereum Go client involve updating import paths and types related to genesis account allocations and trie database configurations. The modifications aim to enhance consistency and potentially improve performance and maintainability by transitioning from older core package structures to newer types and triedb structures.

Changes

Files Change Summary
.../genesis/config.go, .../genesis/genesis.go, .../genesis/layer_two.go, .../state/memory_db.go, .../e2eutils/..., .../external.go, .../setup.go, .../client/l2/..., .../proposer/proposer/abi_test.go Updated types from core.GenesisAlloc to types.GenesisAlloc and from core.GenesisAccount to types.Account.
.../actions/l1_replica_test.go, .../actions/l2_engine_test.go, .../client/l2/db_test.go, .../client/l2/engine_backend_test.go, .../client/mpt/trie.go, .../contracts-bedrock/scripts/go-ffi/differential-testing.go, .../contracts-bedrock/scripts/go-ffi/trie.go Changed import paths from trie to triedb and updated trie database initialization from trie.NewDatabase to triedb.NewDatabase. Adjustments to trie configurations.

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 53f0080 and 03ada72.
Files ignored due to path filters (4)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
  • op-ufm/go.mod is excluded by !**/*.mod
  • op-ufm/go.sum is excluded by !**/*.sum
Files selected for processing (16)
  • op-chain-ops/genesis/config.go (3 hunks)
  • op-chain-ops/genesis/genesis.go (2 hunks)
  • op-chain-ops/genesis/layer_two.go (1 hunks)
  • op-chain-ops/state/memory_db.go (2 hunks)
  • op-e2e/actions/l1_replica_test.go (2 hunks)
  • op-e2e/actions/l2_engine_test.go (3 hunks)
  • op-e2e/e2eutils/addresses.go (1 hunks)
  • op-e2e/e2eutils/setup.go (4 hunks)
  • op-e2e/external.go (2 hunks)
  • op-e2e/setup.go (3 hunks)
  • op-program/client/l2/db_test.go (4 hunks)
  • op-program/client/l2/engine_backend_test.go (2 hunks)
  • op-program/client/mpt/trie.go (3 hunks)
  • op-proposer/proposer/abi_test.go (2 hunks)
  • packages/contracts-bedrock/scripts/go-ffi/differential-testing.go (3 hunks)
  • packages/contracts-bedrock/scripts/go-ffi/trie.go (2 hunks)
Files skipped from review as they are similar to previous changes (16)
  • op-chain-ops/genesis/config.go
  • op-chain-ops/genesis/genesis.go
  • op-chain-ops/genesis/layer_two.go
  • op-chain-ops/state/memory_db.go
  • op-e2e/actions/l1_replica_test.go
  • op-e2e/actions/l2_engine_test.go
  • op-e2e/e2eutils/addresses.go
  • op-e2e/e2eutils/setup.go
  • op-e2e/external.go
  • op-e2e/setup.go
  • op-program/client/l2/db_test.go
  • op-program/client/l2/engine_backend_test.go
  • op-program/client/mpt/trie.go
  • op-proposer/proposer/abi_test.go
  • packages/contracts-bedrock/scripts/go-ffi/differential-testing.go
  • packages/contracts-bedrock/scripts/go-ffi/trie.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@trianglesphere trianglesphere changed the base branch from develop to axel/geth_1_13_14 May 2, 2024 00:22
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we update op-geth. FYI I updated the base to op-geth/1.13.14 merge

@axelKingsley axelKingsley changed the base branch from axel/geth_1_13_14 to develop May 2, 2024 18:15
@axelKingsley
Copy link
Contributor Author

I've changed base back to develop because we can take all the changes from the in-between versions by taking this branch, which is a relatively small accumulation. All interior version changes have their own PRs which pass tests and are approved, so merging this one directly is effectively the same as iteratively merging them.

@axelKingsley axelKingsley requested a review from tynes May 2, 2024 18:56
op-chain-ops/genesis/genesis.go Show resolved Hide resolved
@axelKingsley axelKingsley added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit 2838df8 May 2, 2024
74 checks passed
@axelKingsley axelKingsley deleted the axel/geth_1_13_15 branch May 2, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants