Add check-fjord script to smoke test live chains

[bitwiseguy]

Description

Add a "smoke test" script that can be run against live networks to confirm the Fjord hardfork is active and Fjord features are working correctly.

Tests

Added an e2e test that runs all of the check-fjord script tests against a mock, test env chain.

Metadata

• Fixes https://github.com/ethereum-optimism/protocol-quest/issues/252

[semgrep-app]

Semgrep found 9 golang_fmt_errorf_no_params findings:

• op-chain-ops/cmd/check-fjord/main.go
  • L236 - Triage
  • L242 - Triage
  • L245 - Triage
  • L251 - Triage
  • L258 - Triage
  • L267 - Triage
  • L276 - Triage
  • L304 - Triage
  • L320 - Triage

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}

[semgrep-app]

Semgrep found 4 ban-common-hex2bytes findings:

• op-challenger/game/fault/contracts/faultdisputegame_test.go
  • L188 - Triage
  • L197 - Triage
  • L206 - Triage
  • L215 - Triage

Found banned use of common.Hex2Bytes. Use common.FromHex instead.

_{Ignore this finding from ban-common-hex2bytes.}

[semgrep-app]

Semgrep found 2 golang_fmt_errorf_no_params findings:

• op-chain-ops/upgrades/l1.go
  • L704 - Triage
  • L707 - Triage

No fmt.Errorf invocations without fmt arguments allowed

_{Ignore this finding from golang_fmt_errorf_no_params.}

[coderabbitai]

Walkthrough

Walkthrough

The recent updates enhance the Fjord upgrade verification in Ethereum. Changes include new check functions and configurations in check-fjord, a CLI tool for running checks, and tests ensuring accurate execution against a Fjord-enabled test chain.

Changes

File(s)	Change Summary
op-chain-ops/cmd/check-fjord/checks/checks.go	Added functions/types for Fjord upgrade checks like gas usage, transaction validation, and precompile checks.
op-chain-ops/cmd/check-fjord/main.go	Introduced CLI program with L2 RPC endpoint and test account key flags, and commands for running checks.
op-e2e/system_test.go, op-e2e/check_scripts_test.go	Added tests to verify check-fjord script against Fjord-enabled test chain.

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 23e875d and c5770fe.

Files selected for processing (1)

• op-e2e/check_scripts_test.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• op-e2e/check_scripts_test.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (2)

op-chain-ops/cmd/check-fjord/checks/checks.go (2)

72-79: The CheckFjordConfig struct is well-defined and encapsulates all necessary fields for the checks. Consider adding documentation comments to explain the purpose of each field, especially for public or exported types.

---

364-391: The fjordL1Cost function calculates the L1 cost based on various parameters. The function is well-implemented, but adding inline comments explaining the calculation steps would enhance understanding and maintainability.

[coderabbitai]

Actionable comments posted: 2

[sebastianst]

This looks great!

I propose to move a few things around.

[coderabbitai]

Actionable comments posted: 3