op-e2e: harden WaitForTransaction against tx indexing in progress errors

[sebastianst]

Description

This is a new error by geth that hasn't an exported error type yet, but it indicates that geth is still indexing and so one more try should be done.

Tests

This is used in all e2e tests. If they still pass, and we see a reduction in flakes, then it works.

Additional context

Creates random flakyness in tests. Tried to fix this as part of #10589 but it then made lots of tests fail, so split it out into its own PR. Edit: it's actually that other PR that makes tests fail, not this one.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes in the wait.go file within the op-e2e/e2eutils/geth directory include the addition of the strings package import, modification of the error constant declaration, and refactoring of the error handling logic in the WaitForTransaction function. These updates aim to enhance the error processing mechanism, likely improving the robustness and clarity of the code.

Changes

File Path	Change Summary
op-e2e/e2eutils/geth/wait.go	- Added strings package import - Modified error constant declaration - Refactored error handling logic in WaitForTransaction function

---

Recent Review Details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f706f06 and 3167886.

Files selected for processing (1)

• op-e2e/e2eutils/geth/wait.go (3 hunks)

Additional comments not posted (2)

op-e2e/e2eutils/geth/wait.go (2)

8-8: The import of the strings package is justified as it is used in the error handling logic within WaitForTransaction.

---

20-20: The addition of the errStrTxIdxingInProgress constant is a good practice as it centralizes the error message, enhancing maintainability and readability.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[axelKingsley]

slam dunk, nice improvement and TY for the context in the description.