-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ctb): type definition in ERC721Bridge #10755
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10755 +/- ##
============================================
- Coverage 54.65% 39.26% -15.39%
============================================
Files 37 27 -10
Lines 2944 1821 -1123
Branches 415 415
============================================
- Hits 1609 715 -894
+ Misses 1303 1106 -197
+ Partials 32 0 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
This is great and we can merge it if we bump the semver for the L1 and L2 bridges with a patch + beta, so |
Semgrep found 1 Named return arguments to functions must be appended with an underscore ( Semgrep found 3 Malformed revert statement style. Ignore this finding from sol-style-malformed-revert.Semgrep found 1 Inputs to functions must be prepended with an underscore ( Semgrep found 2 Variable |
* contracts-bedrock: change type of otherBridge in ERC721Bridge to ERC721Bridge * contracts-bedrock: update semver-lock * contracts-bedrock: update snapshots * contracts-bedrock: bump version for L2ERC721Bridge * contracts-bedrock: bump version for L1ERC721Bridge * contracts-bedrock: update semver-lock * contracts-bedrock: update snapshots
context copied from https://github.com/ethereum-optimism/client-pod/issues/601
Found by @tynes and discussed in slack.
See this line, the type is
StandardBridge
but it shouldn't beStandardBridge
because the erc721 bridge never interacts with the erc20 bridge, it should beERC721Bridge
.This does not impact functionality, and just affects integrators calling the
otherBridge
getter. Currently they must either cast the returned value or use their own interface which returns the correct value