Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-supervisor: Write logs to logdb #11046

Merged
merged 1 commit into from
Jul 9, 2024
Merged

op-supervisor: Write logs to logdb #11046

merged 1 commit into from
Jul 9, 2024

Conversation

ajsutton
Copy link
Contributor

Description

Implements the hash scheme for logs and actually writes them to the logdb.

Executing messages aren't extracted yet but basic log information is hashed and written (tracked in #11024). Also doesn't restore state properly on startup, always starting from block 0 (tracked in #11027)

Tests

Added unit tests. Confirmed logs are written when running locally.

Additional context

Add any other context about the problem you're solving.

Metadata

@ajsutton ajsutton requested a review from protolambda June 28, 2024 04:45
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I am unsure about the log-payload hashing. I think we need to specify better what properies we include in the hash, and how it is constructed, and maybe include some versioning.

Base automatically changed from aj/create-logdb to develop June 28, 2024 22:00
@protolambda protolambda enabled auto-merge July 8, 2024 23:02
@protolambda protolambda added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 8, 2024
@ajsutton ajsutton requested a review from a team as a code owner July 9, 2024 01:08
@ajsutton ajsutton requested a review from axelKingsley July 9, 2024 01:08
@ajsutton ajsutton enabled auto-merge July 9, 2024 01:08
@ajsutton ajsutton removed the request for review from axelKingsley July 9, 2024 01:08
@ajsutton ajsutton added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 9, 2024
Executing messages aren't extracted yet but basic log information is hashed and written.
@ajsutton ajsutton enabled auto-merge July 9, 2024 01:51
@ajsutton ajsutton added this pull request to the merge queue Jul 9, 2024
Merged via the queue into develop with commit f269f3f Jul 9, 2024
60 checks passed
@ajsutton ajsutton deleted the aj/extract-logs branch July 9, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop: op-supervisor: Record logs in database
2 participants