-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contracts-bedrock: integrate GovernanceToken
with Alligator
#11168
contracts-bedrock: integrate GovernanceToken
with Alligator
#11168
Conversation
Semgrep found 1 Named return arguments to functions must be appended with an underscore ( Semgrep found 1 Inputs to functions must be prepended with an underscore ( |
3ad02aa
to
ef89210
Compare
7371e01
to
09943d6
Compare
Semgrep found 3 Prefer Semgrep found 1 Inputs to functions must be prepended with an underscore ( |
932f02b
to
00d772c
Compare
Semgrep found 1 Modifiers that don't do something before and after execution are banned. Ignore this finding from ban_non_wraparound_modifiers. |
00d772c
to
1dd6a83
Compare
dd51d86
to
f46c1fd
Compare
|
||
address to; | ||
SubdelegationRules memory subdelegationRules; | ||
uint256 votesCastFactor; |
Check warning
Code scanning / Slither
Uninitialized local variables Medium
9562a76
to
dd7b924
Compare
bca7e51
to
c756097
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/gov-alligator #11168 +/- ##
===================================================
Coverage 16.44% 16.44%
===================================================
Files 8 8
Lines 535 535
Branches 71 71
===================================================
Hits 88 88
Misses 447 447
Flags with carried forward coverage won't be shown. Click here to find out more. |
merging to #11167 so that it's easier to test both Alligator and GovernanceToken. |
This PR implements the specs for
GovernanceToken
as defined in ethereum-optimism/specs#233.Concretely, this allows accounts to be migrated to the
Alligator
, which holds the state and implements the advanced delegation logic on behalf of theGovernanceToken
.