Interop: devnet [draft] #11324
Closed
Interop: devnet [draft] #11324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
protolambda
force-pushed
the
interop-devnet
branch
from
c6f5689 to
4590adf
Compare
|
Blocked by fixing the L1-deploy configuration of the chain setup, i.e. OPStackManager milestone 1 chain configuration to integrate. |
protolambda
force-pushed
the
interop-devnet
branch
from
48a8659 to
15caf68
Compare
mds1
reviewed
Aug 19, 2024
mds1
reviewed
Aug 19, 2024
mds1
reviewed
Aug 19, 2024
mds1
reviewed
Aug 19, 2024
protolambda
force-pushed
the
interop-devnet
branch
from
15caf68 to
b97758d
Compare
|
Path to running local devnet:
And will split this PR up into (A) general forge script improvements/utils + (B) deploy code + (C) interop devnet with CLI calling deploy code. |
protolambda
force-pushed
the
interop-devnet
branch
from
fa901d4 to
f2f8293
Compare
protolambda
changed the base branch from
develop
to
forge-scripts-improvements
protolambda
force-pushed
the
forge-scripts-improvements
branch
from
5293b30 to
eecf8fc
Compare
protolambda
force-pushed
the
interop-devnet
branch
from
f2f8293 to
1cfdd3b
Compare
protolambda
force-pushed
the
interop-devnet
branch
from
f56543a to
cef8c83
Compare
| @@ -25,9 +26,107 @@ struct Deployment { | |||
| /// @notice Useful for accessing deployment artifacts from within scripts. | |||
| /// When a contract is deployed, call the `save` function to write its name and | |||
| /// contract address to disk. Inspired by `forge-deploy`. | |||
| /// @dev This uses the DeploymentRegistry contract, to load/store deployments, | |||
There was a problem hiding this comment.
Prefer @notice over @dev in natspec comments
|
Semgrep found 3 Named return arguments to functions must be appended with an underscore ( Semgrep found 31
Service port is exposed on all interfaces Ignore this finding from port-all-interfaces. |
protolambda
force-pushed
the
interop-devnet
branch
from
cef8c83 to
e98beb1
Compare
|
This PR is getting too noisy due to rebases / errors. Building on top of latest deploy tooling here: #11590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft of a local devnet for Interop.
Tests
Work in progress.
Additional context
The local interop devnet initially started from #10777 but then restarted, to separate out from the legacy devnet, as there were too many incompatibilities (keys of actors, deploy configs, deploy approach, python legacy, etc.) Still, thank you @jinmel for a take on an initial devnet.
Metadata
Fix #11306