-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPSM: Deploy implementation contracts #11539
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
force-pushed
the
opsm/deploy-implementation-contracts
branch
from
August 20, 2024 21:26
bf1949b
to
d75e9d2
Compare
tynes
reviewed
Aug 21, 2024
tynes
reviewed
Aug 21, 2024
tynes
approved these changes
Aug 22, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* feat: scaffold impl deploy script and test * add fault proofs support * appease semgrep * additional semgrep fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 of the architecture described in ethereum-optimism/design-docs#60. This is a follow up to #11480, and the script added in that PR has extensive comments explaining the script architecture
We have no introduced duplication of many utility methods. Once these PRs are both merged, I'll open a third PR to dedupe them, in the interest of keeping PRs small so we can merge them quickly