Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builds for op-deployer, bugfixes, artifacts downloads #12033

Merged
merged 9 commits into from
Sep 21, 2024

Conversation

mslipper
Copy link
Collaborator

Adds Docker builds for op-deployer, makes some bugfixes, and adds support for downloading remote artifacts.

@mslipper mslipper requested review from a team as code owners September 20, 2024 17:52
Copy link
Contributor

@bitwiseguy bitwiseguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left a few minor questions/comments

op-chain-ops/deployer/apply.go Outdated Show resolved Hide resolved
ops/docker/op-stack-go/Dockerfile Outdated Show resolved Hide resolved
op-chain-ops/deployer/init.go Show resolved Hide resolved
Copy link
Contributor

semgrep-app bot commented Sep 21, 2024

Semgrep found 3 golang_fmt_errorf_no_params findings:

  • op-supervisor/supervisor/backend/db/safety_checkers_test.go
  • op-supervisor/supervisor/backend/db/db_test.go

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

@mslipper mslipper requested a review from a team as a code owner September 21, 2024 04:03
mslipper and others added 9 commits September 20, 2024 22:09
Adds Docker builds for op-deployer, makes some bugfixes, and adds support for downloading remote artifacts.
…action ("zip slip")

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (0543bf7) to head (f554dda).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12033      +/-   ##
===========================================
- Coverage    79.10%   78.87%   -0.24%     
===========================================
  Files           41       41              
  Lines         3437     3437              
===========================================
- Hits          2719     2711       -8     
- Misses         548      557       +9     
+ Partials       170      169       -1     
Flag Coverage Δ
cannon-go-tests 78.87% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@mslipper mslipper added this pull request to the merge queue Sep 21, 2024
Merged via the queue into develop with commit c5007bb Sep 21, 2024
66 checks passed
@mslipper mslipper deleted the feat/op-deployer-6 branch September 21, 2024 04:34
barnabasbusa added a commit to ethpandaops/optimism-package that referenced this pull request Sep 25, 2024
Depends on ethereum-optimism/optimism#12033.

---------

Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…ptimism#12033)

* Add builds for op-deployer, bugfixes, artifacts downloads

Adds Docker builds for op-deployer, makes some bugfixes, and adds support for downloading remote artifacts.

* Apply code scanning fix for arbitrary file access during archive extraction ("zip slip")

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* fix compile error

* lint

* fix test

* Update from code review, add docker build

* fix versioning

* remove errant dispatch

* update target

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants