-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add builds for op-deployer, bugfixes, artifacts downloads #12033
Conversation
dc573b6
to
9e05780
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just left a few minor questions/comments
Semgrep found 3
No |
Adds Docker builds for op-deployer, makes some bugfixes, and adds support for downloading remote artifacts.
…action ("zip slip") Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
0f2a06c
to
f554dda
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12033 +/- ##
===========================================
- Coverage 79.10% 78.87% -0.24%
===========================================
Files 41 41
Lines 3437 3437
===========================================
- Hits 2719 2711 -8
- Misses 548 557 +9
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Depends on ethereum-optimism/optimism#12033. --------- Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com> Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
…ptimism#12033) * Add builds for op-deployer, bugfixes, artifacts downloads Adds Docker builds for op-deployer, makes some bugfixes, and adds support for downloading remote artifacts. * Apply code scanning fix for arbitrary file access during archive extraction ("zip slip") Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * fix compile error * lint * fix test * Update from code review, add docker build * fix versioning * remove errant dispatch * update target --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Adds Docker builds for op-deployer, makes some bugfixes, and adds support for downloading remote artifacts.