Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: justfile clean command #12092

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: justfile clean command #12092

merged 2 commits into from
Sep 24, 2024
+0 −2

Conversation

blmalone
Copy link
Contributor

@blmalone blmalone commented Sep 24, 2024 •
edited
Loading

@blmalone Graphite App
Copy link
Contributor Author

blmalone commented Sep 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone mentioned this pull request Sep 24, 2024
Merged
@blmalone blmalone marked this pull request as ready for review September 24, 2024 18:43
@blmalone blmalone requested a review from a team as a code owner September 24, 2024 18:43
@blmalone blmalone requested review from mds1 and removed request for mds1 September 24, 2024 18:43
maurelian
maurelian approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blmalone blmalone enabled auto-merge September 24, 2024 19:12
@blmalone blmalone added this pull request to the merge queue Sep 24, 2024
Merged via the queue into develop with commit 1ee7ea1 Sep 24, 2024
62 of 64 checks passed
@blmalone blmalone deleted the 09-24-fix_justfile_clean_command branch September 24, 2024 19:29
This was referenced Sep 25, 2024
Merged
Merged
Merged
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@blmalone @samlaf
fix: justfile clean command (ethereum-optimism#12092)
4bfcbd0 
* fix: justfile clean command

* fix: removed stale comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurelian maurelian maurelian approved these changes

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blmalone @mds1 @maurelian