Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Build the cannon docker image and publish on cannon release tags #12100

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

ajsutton
Copy link
Contributor

Description

Actually publishing the cannon docker image allows it to be used as the source for legacy versions of cannon to provide backwards compatibility.

@ajsutton ajsutton requested a review from a team as a code owner September 25, 2024 04:37
@ajsutton ajsutton requested review from sebastianst and Inphi and removed request for sebastianst September 25, 2024 04:37
@ajsutton
Copy link
Contributor Author

Note: May need to adjust this once #12072 is merged to ensure the docker image contains the separate implementation versions, not just multicannon or we'll wind up playing Russian dolls...

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ajsutton
Copy link
Contributor Author

Copied the implementations over to the final docker image. Conveniently this means we should only ever need to pull one cannon docker image to get all the implementations we need since each release copies in all the embed versions multicannon supports, including the ones that were copied from a previous image so we can just grab them from there.

@ajsutton ajsutton enabled auto-merge September 25, 2024 04:50
@ajsutton ajsutton added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit decf451 Sep 25, 2024
67 checks passed
@ajsutton ajsutton deleted the aj/cannon-docker branch September 25, 2024 05:07
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…ags (ethereum-optimism#12100)

* cannon: Build the cannon docker image and publish on cannon release tags.

* ci: Add docker builds as dependencies so they prevent merging if they fail.

* cannon: Include specific implementation builds in final docker image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants