Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-deployer): asterisc bootstrap CLI #13113

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Conversation

clabby
Copy link
Member

@clabby clabby commented Nov 27, 2024

Overview

Adds a new subcommand to op-deployer's bootstrap mode that can deploy the RISCV.sol vm.

Copy link
Member Author

clabby commented Nov 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@clabby clabby force-pushed the cl/asterisc-bootstrap branch from b8408ec to 0c3fbde Compare November 27, 2024 00:46
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 133 lines in your changes missing coverage. Please review.

Project coverage is 42.69%. Comparing base (72eb311) to head (29970ad).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% 119 Missing ⚠️
op-deployer/pkg/deployer/opcm/asterisc.go 57.57% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13113      +/-   ##
===========================================
- Coverage    44.46%   42.69%   -1.78%     
===========================================
  Files          798      744      -54     
  Lines        71682    67169    -4513     
===========================================
- Hits         31874    28675    -3199     
+ Misses       37224    36084    -1140     
+ Partials      2584     2410     -174     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/opcm/asterisc.go 57.57% <57.57%> (ø)
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% <0.00%> (ø)

... and 63 files with indirect coverage changes

@clabby clabby marked this pull request as ready for review November 27, 2024 01:08
@clabby clabby requested review from a team as code owners November 27, 2024 01:08
Copy link
Collaborator

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once comments are addressed

op-deployer/pkg/deployer/opcm/asterisc.go Show resolved Hide resolved
op-deployer/pkg/deployer/opcm/asterisc.go Show resolved Hide resolved
op-deployer/pkg/deployer/bootstrap/asterisc.go Outdated Show resolved Hide resolved
op-deployer/pkg/deployer/bootstrap/asterisc.go Outdated Show resolved Hide resolved
@clabby clabby force-pushed the cl/asterisc-bootstrap branch from c0acfa8 to 0c70b54 Compare November 27, 2024 06:32
@clabby clabby force-pushed the cl/asterisc-bootstrap branch from 0c70b54 to 29970ad Compare November 27, 2024 07:18
@clabby clabby enabled auto-merge November 27, 2024 07:18
@mslipper
Copy link
Collaborator

flake is known, re-running

@clabby clabby added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit af169db Nov 27, 2024
43 checks passed
@clabby clabby deleted the cl/asterisc-bootstrap branch November 27, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants