Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(op-deployer): Fork in asterisc + dispute game + delayed weth bootstrap jobs #13229

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented Dec 4, 2024

Overview

Adds remote forking for the asterisc, disputegame, and delayedweth bootstrap tasks.

@clabby clabby requested a review from a team as a code owner December 4, 2024 19:23
@clabby clabby requested a review from mbaxter December 4, 2024 19:23
@clabby clabby force-pushed the cl/dispute-game-bootstrap-fork branch from 4b8a625 to 9697726 Compare December 4, 2024 19:24
@clabby clabby requested review from mslipper and removed request for mbaxter December 4, 2024 19:24
@clabby clabby force-pushed the cl/dispute-game-bootstrap-fork branch from 9697726 to 2e174d5 Compare December 4, 2024 19:25
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 42.67%. Comparing base (4ce84f1) to head (2e174d5).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/dispute_game.go 0.00% 21 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 0.00% 18 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13229      +/-   ##
===========================================
- Coverage    44.25%   42.67%   -1.59%     
===========================================
  Files          807      751      -56     
  Lines        72707    68051    -4656     
===========================================
- Hits         32177    29041    -3136     
+ Misses       37914    36566    -1348     
+ Partials      2616     2444     -172     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/asterisc.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 7.36% <0.00%> (-0.64%) ⬇️
op-deployer/pkg/deployer/bootstrap/dispute_game.go 15.29% <0.00%> (+1.16%) ⬆️

... and 66 files with indirect coverage changes

@clabby clabby requested a review from ajsutton December 4, 2024 19:55
@mslipper mslipper added this pull request to the merge queue Dec 4, 2024
Merged via the queue into develop with commit 260f36e Dec 4, 2024
44 checks passed
@mslipper mslipper deleted the cl/dispute-game-bootstrap-fork branch December 4, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants