Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(op-deployer): Accept existing impl in DelayedWETH bootstrap task #13250

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented Dec 5, 2024

Overview

Alters the delayedweth bootstrap task to take the existing implementation as an input, rather than pulling it from the standard versions toml.

@clabby clabby requested review from a team as code owners December 5, 2024 00:06
@clabby clabby requested review from mslipper and removed request for ajsutton and AmadiMichael December 5, 2024 00:06
@clabby clabby force-pushed the cl/delayed-weth-impl-param branch from a6720e2 to 874831a Compare December 5, 2024 00:07
@mslipper mslipper added this pull request to the merge queue Dec 5, 2024
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mslipper mslipper removed this pull request from the merge queue due to a manual request Dec 5, 2024
@clabby clabby enabled auto-merge December 5, 2024 00:45
@clabby clabby added this pull request to the merge queue Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.92%. Comparing base (d3fbc57) to head (084f195).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d3fbc57) and HEAD (084f195). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d3fbc57) HEAD (084f195)
cannon-go-tests-32 1 0
cannon-go-tests-64 1 0
contracts-bedrock-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13250       +/-   ##
============================================
- Coverage    64.58%   42.92%   -21.66%     
============================================
  Files          175      754      +579     
  Lines        11535    68013    +56478     
  Branches      1133        0     -1133     
============================================
+ Hits          7450    29197    +21747     
- Misses        3830    36345    +32515     
- Partials       255     2471     +2216     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/flags.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/opcm/delayed_weth.go 57.57% <ø> (ø)
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 8.69% <66.66%> (ø)

... and 926 files with indirect coverage changes

Merged via the queue into develop with commit a88f639 Dec 5, 2024
45 checks passed
@clabby clabby deleted the cl/delayed-weth-impl-param branch December 5, 2024 01:02
sigma pushed a commit that referenced this pull request Dec 19, 2024
…ask (#13250)

* chore(op-deployer): Accept existing impl in `DelayedWETH` bootstrap task

* remove check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants