Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Clean up to use latest libs #13257

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Dec 5, 2024

No description provided.

@mslipper mslipper requested a review from a team as a code owner December 5, 2024 07:06
@mslipper mslipper requested a review from bitwiseguy December 5, 2024 07:06
@mslipper mslipper force-pushed the feat/op-deployer-cleanup branch from df7f378 to f18fa3e Compare December 5, 2024 07:06
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 43.13%. Comparing base (94056b9) to head (f18fa3e).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/bootstrap/mips.go 0.00% 6 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 0.00% 3 Missing ⚠️
op-deployer/pkg/deployer/bootstrap/dispute_game.go 0.00% 3 Missing ⚠️
op-deployer/pkg/deployer/opcm/opchain.go 0.00% 1 Missing ⚠️
op-deployer/pkg/deployer/opcm/opcm.go 0.00% 1 Missing ⚠️
op-deployer/pkg/deployer/opcm/superchain.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13257      +/-   ##
===========================================
- Coverage    46.35%   43.13%   -3.23%     
===========================================
  Files          929      754     -175     
  Lines        79559    67826   -11733     
  Branches      1133        0    -1133     
===========================================
- Hits         36879    29255    -7624     
+ Misses       39943    36108    -3835     
+ Partials      2737     2463     -274     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/opcm/asterisc.go 66.66% <100.00%> (+9.09%) ⬆️
op-deployer/pkg/deployer/opcm/delayed_weth.go 66.66% <100.00%> (+9.09%) ⬆️
op-deployer/pkg/deployer/opcm/dispute_game.go 66.66% <100.00%> (+9.09%) ⬆️
op-deployer/pkg/deployer/opcm/mips.go 66.66% <100.00%> (+9.09%) ⬆️
op-deployer/pkg/deployer/opcm/opchain.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/opcm/opcm.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/opcm/superchain.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/bootstrap/delayed_weth.go 9.45% <0.00%> (+0.76%) ⬆️
op-deployer/pkg/deployer/bootstrap/dispute_game.go 16.56% <0.00%> (+1.26%) ⬆️
op-deployer/pkg/deployer/bootstrap/mips.go 0.00% <0.00%> (ø)

... and 186 files with indirect coverage changes

Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mslipper mslipper added this pull request to the merge queue Dec 5, 2024
Merged via the queue into develop with commit ee5c794 Dec 5, 2024
44 checks passed
@mslipper mslipper deleted the feat/op-deployer-cleanup branch December 5, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants