Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Add more FP deploy scripts #13325

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

Adds additional op-deployer scripts to support alternative fault proof implementations. This is a prerequisite to deleting the allocs files, since many tests need a fast dispute game and an alphabet VM.

@mslipper mslipper requested review from a team as code owners December 10, 2024 05:05
@mslipper mslipper force-pushed the feat/fp-deploy-scripts branch 5 times, most recently from 3cecdcd to bf496ec Compare December 10, 2024 05:12
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 72.54902% with 14 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (70e71c2) to head (bc27689).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/opcm/script.go 55.00% 6 Missing and 3 partials ⚠️
op-chain-ops/script/script.go 0.00% 2 Missing ⚠️
op-deployer/pkg/deployer/opcm/opchain.go 0.00% 1 Missing ⚠️
op-deployer/pkg/deployer/opcm/opcm.go 0.00% 1 Missing ⚠️
op-deployer/pkg/deployer/opcm/superchain.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13325      +/-   ##
===========================================
- Coverage    47.30%   42.94%   -4.37%     
===========================================
  Files          928      762     -166     
  Lines        78145    68427    -9718     
  Branches       849        0     -849     
===========================================
- Hits         36967    29383    -7584     
+ Misses       38467    36550    -1917     
+ Partials      2711     2494     -217     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/opcm/alphabet.go 100.00% <100.00%> (ø)
op-deployer/pkg/deployer/opcm/asterisc.go 66.66% <100.00%> (ø)
op-deployer/pkg/deployer/opcm/delayed_weth.go 66.66% <100.00%> (ø)
op-deployer/pkg/deployer/opcm/dispute_game.go 66.66% <100.00%> (ø)
...deployer/pkg/deployer/opcm/dispute_game_factory.go 100.00% <100.00%> (ø)
op-deployer/pkg/deployer/opcm/mips.go 66.66% <100.00%> (ø)
op-deployer/pkg/deployer/opcm/preimage_oracle.go 100.00% <100.00%> (ø)
op-deployer/pkg/deployer/opcm/proxy.go 50.00% <100.00%> (ø)
op-deployer/pkg/deployer/opcm/opchain.go 0.00% <0.00%> (ø)
op-deployer/pkg/deployer/opcm/opcm.go 0.00% <0.00%> (ø)
... and 3 more

... and 177 files with indirect coverage changes

Adds additional op-deployer scripts to support alternative fault proof implementations. This is a prerequisite to deleting the allocs files, since many tests need a fast dispute game and an alphabet VM.
@mslipper mslipper force-pushed the feat/fp-deploy-scripts branch from bf496ec to bc27689 Compare December 10, 2024 05:18
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mslipper mslipper added this pull request to the merge queue Dec 10, 2024
Merged via the queue into develop with commit eabf704 Dec 10, 2024
42 checks passed
@mslipper mslipper deleted the feat/fp-deploy-scripts branch December 10, 2024 15:58
sigma pushed a commit that referenced this pull request Dec 19, 2024
Adds additional op-deployer scripts to support alternative fault proof implementations. This is a prerequisite to deleting the allocs files, since many tests need a fast dispute game and an alphabet VM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants