Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Remove unsued disputegame bootstrap flags #13369

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Dec 12, 2024

  • Removes some flags that aren't used to deploy a dispute game.
  • Also improves the cli description of these flags.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.08%. Comparing base (5bdc9ac) to head (008785a).

❗ There is a different number of reports uploaded between BASE (5bdc9ac) and HEAD (008785a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (5bdc9ac) HEAD (008785a)
cannon-go-tests-32 2 1
cannon-go-tests-64 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13369       +/-   ##
============================================
- Coverage    65.63%   47.08%   -18.55%     
============================================
  Files          184      939      +755     
  Lines        11948    78469    +66521     
  Branches       796      796               
============================================
+ Hits          7842    36950    +29108     
- Misses        3836    38795    +34959     
- Partials       270     2724     +2454     
Flag Coverage Δ
cannon-go-tests-32 62.23% <ø> (-1.98%) ⬇️
cannon-go-tests-64 57.20% <ø> (-1.63%) ⬇️
contracts-bedrock-tests 89.14% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/flags.go 0.00% <ø> (ø)

... and 780 files with indirect coverage changes

@Inphi Inphi requested a review from mslipper December 12, 2024 02:07
@Inphi Inphi marked this pull request as ready for review December 12, 2024 02:07
@Inphi Inphi requested a review from a team as a code owner December 12, 2024 02:07
@mslipper mslipper added this pull request to the merge queue Dec 12, 2024
Merged via the queue into develop with commit 12862e7 Dec 12, 2024
42 checks passed
@mslipper mslipper deleted the inphi/op-deployer-chore branch December 12, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants