-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-deployer: Holocene deployment support #13483
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13483 +/- ##
===========================================
- Coverage 47.42% 43.03% -4.39%
===========================================
Files 944 776 -168
Lines 78864 69380 -9484
Branches 803 0 -803
===========================================
- Hits 37400 29858 -7542
+ Misses 38698 36980 -1718
+ Partials 2766 2542 -224
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4f9a380
to
32b3d88
Compare
The artifacts for v1.8.0 were generated from the tag `op-contracts-v180-artifacts-base`, which points to `proposal/contracts/v1.8.0` with the non-proxied OPCM backported. The OPCM was deployed using the `opcm bootstrap` command. The PDG blueprints were updated using a custom script which you can find at the `op-contracts-v180-blueprints-script` [tag](a709118). As part of this PR, I also added a bunch of tests to assert that the semver versions of deployed contracts are correct. I'll add similar tests for mainnet once the gov vote passes.
32b3d88
to
6cf283d
Compare
We have a branch The branch Of course, we also have all the necessary changes in Additionally, we have the new When we run op-deployer bootstrap opcm from this branch, it'll use the new ASR & PDG blueprints that Slipper manually deployed along with the existing blueprints for v180. |
Reviewed this live with @blmalone, and reproduced the artifacts hash locally on his machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the artifacts hash: 361ebf1f520c20d932695b00babfff6923ce2530cd05b2776eb74e07038898a6
is created from the tag op-contracts-v180-artifacts-base
.
Looked at the op-contracts-v180-artifacts-base
diff with the v180 backport branch proposal/op-contracts/v1.8.0-opcm-backport
. The changes introduced makes sense.
The artifacts for v1.8.0 were generated from the tag
op-contracts-v180-artifacts-base
, which points to the branchproposal/contracts/v1.8.0-opcm-backport
. The backport branch consists ofproposal/contracts/v1.8.0
with the non-proxied OPCM backported.The OPCM was deployed using the
opcm bootstrap
command. The PDG blueprints were updated using a custom script which you can find at theop-contracts-v180-blueprints-script
tag.As part of this PR, I also added a bunch of tests to assert that the semver versions of deployed contracts are correct. I'll add similar tests for mainnet once the gov vote passes.