Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: Holocene deployment support #13483

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Dec 19, 2024

The artifacts for v1.8.0 were generated from the tag op-contracts-v180-artifacts-base, which points to the branch proposal/contracts/v1.8.0-opcm-backport. The backport branch consists of proposal/contracts/v1.8.0 with the non-proxied OPCM backported.

The OPCM was deployed using the opcm bootstrap command. The PDG blueprints were updated using a custom script which you can find at the op-contracts-v180-blueprints-script tag.

As part of this PR, I also added a bunch of tests to assert that the semver versions of deployed contracts are correct. I'll add similar tests for mainnet once the gov vote passes.

@mslipper mslipper requested review from a team as code owners December 19, 2024 18:35
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 25 lines in your changes missing coverage. Please review.

Project coverage is 43.03%. Comparing base (92513ea) to head (6cf283d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
op-deployer/pkg/deployer/standard/standard.go 65.71% 11 Missing and 1 partial ⚠️
op-deployer/pkg/deployer/artifacts/locator.go 63.15% 4 Missing and 3 partials ⚠️
op-deployer/pkg/deployer/apply.go 58.33% 3 Missing and 2 partials ⚠️
op-deployer/pkg/deployer/state/intent.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13483      +/-   ##
===========================================
- Coverage    47.42%   43.03%   -4.39%     
===========================================
  Files          944      776     -168     
  Lines        78864    69380    -9484     
  Branches       803        0     -803     
===========================================
- Hits         37400    29858    -7542     
+ Misses       38698    36980    -1718     
+ Partials      2766     2542     -224     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/bootstrap/opcm.go 47.53% <100.00%> (ø)
op-deployer/pkg/deployer/pipeline/init.go 59.40% <100.00%> (ø)
op-deployer/pkg/deployer/state/intent.go 45.37% <0.00%> (ø)
op-deployer/pkg/deployer/apply.go 51.27% <58.33%> (+1.05%) ⬆️
op-deployer/pkg/deployer/artifacts/locator.go 74.64% <63.15%> (+1.57%) ⬆️
op-deployer/pkg/deployer/standard/standard.go 51.97% <65.71%> (-1.41%) ⬇️

... and 179 files with indirect coverage changes

@mslipper mslipper force-pushed the feat/holocene-version branch from 4f9a380 to 32b3d88 Compare December 20, 2024 00:47
The artifacts for v1.8.0 were generated from the tag `op-contracts-v180-artifacts-base`, which points to `proposal/contracts/v1.8.0` with the non-proxied OPCM backported.

The OPCM was deployed using the `opcm bootstrap` command. The PDG blueprints were updated using a custom script which you can find at the `op-contracts-v180-blueprints-script` [tag](a709118).

As part of this PR, I also added a bunch of tests to assert that the semver versions of deployed contracts are correct. I'll add similar tests for mainnet once the gov vote passes.
@mslipper mslipper force-pushed the feat/holocene-version branch from 32b3d88 to 6cf283d Compare December 20, 2024 00:48
@mslipper mslipper requested a review from blmalone December 20, 2024 01:05
@blmalone
Copy link
Contributor

We have a branch proposal/op-contracts/v1.8.0-opcm-backport that has the following diff with proposal/op-contracts/v1.8.0: proposal/op-contracts/v1.8.0...proposal/op-contracts/v1.8.0-opcm-backport. Slipper has added a script that deploys blueprints for a specified contract (i.e. PDG, ASR).

The branch proposal/op-contracts/v1.8.0-opcm-backport is an extension of the tag op-contracts-v180-artifacts-base - diff here. The branch includes the DeployBlueprint.s.sol script.

Of course, we also have all the necessary changes in DeployImplementation.s.sol so that op-deployer can work with the artifact bundle that's made from this backport commit (and stored in GCP).

Additionally, we have the new DeployOPCM.s.sol. This is a more recent script that deploys OPCM on it's own from standard data. That is, this script takes as input already deployed blueprints, implementations etc (anything OPCM needs).

When we run op-deployer bootstrap opcm from this branch, it'll use the new ASR & PDG blueprints that Slipper manually deployed along with the existing blueprints for v180.

@mslipper
Copy link
Collaborator Author

Reviewed this live with @blmalone, and reproduced the artifacts hash locally on his machine.

Copy link
Contributor

@blmalone blmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the artifacts hash: 361ebf1f520c20d932695b00babfff6923ce2530cd05b2776eb74e07038898a6 is created from the tag op-contracts-v180-artifacts-base.

Looked at the op-contracts-v180-artifacts-base diff with the v180 backport branch proposal/op-contracts/v1.8.0-opcm-backport. The changes introduced makes sense.

@mslipper mslipper added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 0067de0 Dec 20, 2024
43 checks passed
@mslipper mslipper deleted the feat/holocene-version branch December 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants