Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop,wip: Walkback on conflict reset failures. #13641

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

tyler-smith
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (83fb599) to head (5fcec12).
Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
op-supervisor/supervisor/backend/syncnode/node.go 65.95% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13641      +/-   ##
===========================================
- Coverage    47.07%   42.94%   -4.13%     
===========================================
  Files          950      784     -166     
  Lines        79617    70294    -9323     
  Branches       761        0     -761     
===========================================
- Hits         37476    30190    -7286     
+ Misses       39319    37492    -1827     
+ Partials      2822     2612     -210     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-supervisor/supervisor/backend/syncnode/node.go 46.91% <65.95%> (+5.18%) ⬆️

... and 175 files with indirect coverage changes

@tyler-smith tyler-smith changed the title wip: Walkback on conflict reset failures. interop,wip: Walkback on conflict reset failures. Jan 9, 2025
return m.Node.Reset(ctx, unsafe, safe, finalized)
}

func (m *ManagedNode) walkBackToCommonAncestor(ctx context.Context, start uint64, unsafe, finalized eth.BlockID) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add "_linear" to this function name to indicate it could be replaced with more efficient searchers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants