-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interop,wip: Walkback on conflict reset failures. #13641
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13641 +/- ##
===========================================
- Coverage 47.07% 42.94% -4.13%
===========================================
Files 950 784 -166
Lines 79617 70294 -9323
Branches 761 0 -761
===========================================
- Hits 37476 30190 -7286
+ Misses 39319 37492 -1827
+ Partials 2822 2612 -210
Flags with carried forward coverage won't be shown. Click here to find out more.
|
return m.Node.Reset(ctx, unsafe, safe, finalized) | ||
} | ||
|
||
func (m *ManagedNode) walkBackToCommonAncestor(ctx context.Context, start uint64, unsafe, finalized eth.BlockID) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add "_linear" to this function name to indicate it could be replaced with more efficient searchers
No description provided.