Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump kontrol version, and make output checks more robust #13697

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Jan 10, 2025

Some CI failures occurred due to silent failure of kontrol build (so CI should have failed earlier than it did). The newest version of kontrol has a fix for this, and we also update run-kontrl.sh to check for failure explicitly

@mds1 mds1 requested review from a team as code owners January 10, 2025 18:03
@mds1 mds1 requested a review from smartcontracts January 10, 2025 18:03
@mds1 mds1 enabled auto-merge January 10, 2025 18:07
Copy link
Contributor

@JuanCoRo JuanCoRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic below the new changes is subsumed. So maybe consider removing these lines:

if [ "${results[0]}" -ne 0 ] && [ "${results[1]}" -ne 0 ]; then
  echo "Kontrol Build and Prove Failed"
  exit 1
elif [ "${results[0]}" -ne 0 ]; then
  echo "Kontrol Build Failed"
  exit 1
elif [ "${results[1]}" -ne 0 ]; then
  echo "Kontrol Prove Failed"
  exit 2
else

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.03%. Comparing base (3a97042) to head (301128f).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13697      +/-   ##
===========================================
- Coverage    47.23%   47.03%   -0.20%     
===========================================
  Files          953      953              
  Lines        79730    79730              
  Branches       766      766              
===========================================
- Hits         37657    37498     -159     
- Misses       39190    39394     +204     
+ Partials      2883     2838      -45     
Flag Coverage Δ
cannon-go-tests-32 62.26% <ø> (ø)
cannon-go-tests-64 57.35% <ø> (ø)
contracts-bedrock-tests 87.90% <ø> (-2.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

@mds1
Copy link
Contributor Author

mds1 commented Jan 10, 2025

Nice catch @JuanCoRo, fixed in 301128f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants