Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts-bedrock: fix slither #2898

Merged
merged 1 commit into from
Jul 5, 2022
Merged

contracts-bedrock: fix slither #2898

merged 1 commit into from
Jul 5, 2022

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 29, 2022

Description
Fixes slither to work in CI, this is a temp fix until we can configure the outdir for build-info using foundry, see https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/3883/workflows/d23c46f9-501a-4853-9305-d12ff1a12d0b/jobs/52916/steps

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022

⚠️ No Changeset found

Latest commit: ac21944

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes tynes requested a review from maurelian June 29, 2022 23:28
@tynes
Copy link
Contributor Author

tynes commented Jun 30, 2022

PR in ethers-rs to make the outdir configurable: gakonst/ethers-rs#1433
Will need follow up PRs in foundry + hh plugin which should be straight forward to implement

@tynes tynes merged commit 13feec9 into develop Jul 5, 2022
@tynes tynes deleted the fix/slither branch July 5, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants