-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci-builder: update geth version #3714
Conversation
🦋 Changeset detectedLatest commit: 040ea97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a cool feature, but depends on a very recent version of geth & abigen. Getting this merged seems worth it, but it needs to be documented in where we list setup requirements & communicated to the whole team.
Good call, I was trying to fix #3680 I can add something to the docs |
We really need to add this to the docs. #3343 talks about this issue too. |
Updates the version of `abigen` that is used in the `ci-builder` so that it produces bindings that do not parse JSON every time that an instance of the binding is created. The change in geth is here: ethereum/go-ethereum#25574 Fixes the additional diff found here: https://github.com/ethereum-optimism/optimism/pull/3680/files Right now we do not have a guarantee that local devs use a specific version of `abigen`. After this is merged, all devs would need to use `v1.10.25`. Devs could use higher versions but risk running into problems if there are more changes to `abigen` in the future.
I documented how to install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Updates the version of
abigen
that is used in theci-builder
so that it produces bindings that do not parse JSON every time that an instance of the binding is created.The change in geth is here: ethereum/go-ethereum#25574
Fixes the additional diff found here: https://github.com/ethereum-optimism/optimism/pull/3680/files
Right now we do not have a guarantee that local devs use a specific version of
abigen
. After this is merged, all devs would need to usev1.10.25
. Devs could use higher versions but risk running into problems if there are more changes toabigen
in the future.