-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-e2e: pending block test + op-geth update #5736
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
321e31f
to
83d42aa
Compare
03e6761
to
57e39b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against this as-is but I worry a bit about the race conditions involved with assertions about the pending block when we aren't controlling block building timing.
57e39b0
to
e00113e
Compare
Will look into adding the additional geth tests now, but think we can also choose to merge with current tests as-is if there is any urgency, since it covers the pending-block behavior, and we also already did an internal devnet test (see notion doc). |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5736 +/- ##
========================================
Coverage 42.27% 42.28%
========================================
Files 464 464
Lines 30078 30078
Branches 876 876
========================================
+ Hits 12716 12719 +3
+ Misses 16360 16359 -1
+ Partials 1002 1000 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
…nding-block number usage
1d7ced2
to
c5daf6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Tests that the pending block matches the latest block, a change introduced in ethereum-optimism/op-geth#93
Added a temporaryMatches latestgo.mod
change so it runs CI with that op-geth PR. We should merge the geth PR first, and then update the go.mod to point at the main branch.optimism
branch op-geth commit now (previous v1.11.6 changes were included before this PR already, and don't really affect the op-node other than e2e testing, this strictly introduces the receipt L1-fee overhead metadata fix and the pending-block change).