-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fault-detector: remove pre-bedrock support and update tests #6095
Conversation
🦋 Changeset detectedLatest commit: cda9d84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for opstack-docs canceled.
|
Hey @zchn! This PR has merge conflicts. Please fix them before continuing review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Few comments on removing the bedrock option and related flags
@zchn Pushed a commit with the diff to the |
…optimism into k0621/sec-90-fd-tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6095 +/- ##
===========================================
+ Coverage 45.68% 45.79% +0.11%
===========================================
Files 439 439
Lines 28319 28272 -47
Branches 694 686 -8
===========================================
+ Hits 12937 12947 +10
+ Misses 14330 14275 -55
+ Partials 1052 1050 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
No description provided.