Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault-detector: remove pre-bedrock support and update tests #6095

Merged
merged 13 commits into from
Jun 23, 2023

Conversation

zchn
Copy link
Contributor

@zchn zchn commented Jun 21, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

🦋 Changeset detected

Latest commit: cda9d84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/fault-detector Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit cda9d84
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6494fde5b9c0260008c5fb66

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

Hey @zchn! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 21, 2023
@mergify mergify bot removed the conflict label Jun 21, 2023
@zchn zchn marked this pull request as ready for review June 21, 2023 21:00
@zchn zchn requested a review from a team as a code owner June 21, 2023 21:00
Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few comments on removing the bedrock option and related flags

packages/fault-detector/src/service.ts Outdated Show resolved Hide resolved
packages/fault-detector/src/service.ts Outdated Show resolved Hide resolved
packages/fault-detector/src/helpers.ts Outdated Show resolved Hide resolved
@tynes
Copy link
Contributor

tynes commented Jun 22, 2023

@zchn Pushed a commit with the diff to the yarn.lock at 3b5bcc8

@zchn
Copy link
Contributor Author

zchn commented Jun 23, 2023

@zchn Pushed a commit with the diff to the yarn.lock at 3b5bcc8

thank you mark!

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #6095 (cda9d84) into develop (505751c) will increase coverage by 0.11%.
The diff coverage is 23.52%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6095      +/-   ##
===========================================
+ Coverage    45.68%   45.79%   +0.11%     
===========================================
  Files          439      439              
  Lines        28319    28272      -47     
  Branches       694      686       -8     
===========================================
+ Hits         12937    12947      +10     
+ Misses       14330    14275      -55     
+ Partials      1052     1050       -2     
Flag Coverage Δ
bedrock-go-tests 45.01% <ø> (+0.04%) ⬆️
cannon-go-tests 61.71% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 58.12% <ø> (ø)
core-utils-tests 48.47% <ø> (ø)
fault-detector-tests 37.22% <23.52%> (+7.70%) ⬆️
sdk-tests 39.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fault-detector/src/service.ts 8.69% <2.50%> (+2.52%) ⬆️
packages/fault-detector/src/helpers.ts 86.44% <100.00%> (ø)

... and 2 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit e498563 into develop Jun 23, 2023
@OptimismBot OptimismBot deleted the k0621/sec-90-fd-tests branch June 23, 2023 04:09
@mergify mergify bot removed the on-merge-train label Jun 23, 2023
This was referenced Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants