Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contracts-bedrock: lint lib position tests #6152

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 26, 2023

Description

Typo in succeeds

@tynes tynes requested a review from a team as a code owner June 26, 2023 20:50
@tynes tynes requested a review from maurelian June 26, 2023 20:50
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: cbdbd8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit cbdbd8e
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6499fe4e6698ca0008436af5

@github-actions github-actions bot added the C-protocol-critical Category: Modifies protocol-critical code label Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #6152 (cbdbd8e) into develop (33528ef) will decrease coverage by 0.65%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6152      +/-   ##
===========================================
- Coverage    44.57%   43.92%   -0.65%     
===========================================
  Files          441      396      -45     
  Lines        28931    26776    -2155     
  Branches       675      533     -142     
===========================================
- Hits         12895    11761    -1134     
+ Misses       14984    13998     -986     
+ Partials      1052     1017      -35     
Flag Coverage Δ
bedrock-go-tests 43.70% <ø> (+0.08%) ⬆️
cannon-go-tests ?
common-ts-tests ?
contracts-bedrock-tests 58.16% <ø> (ø)
core-utils-tests ?
fault-detector-tests 26.95% <ø> (ø)
sdk-tests 39.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

@tynes tynes merged commit 9087460 into develop Jun 26, 2023
@tynes tynes deleted the fix/lib-position-lint branch June 26, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-protocol-critical Category: Modifies protocol-critical code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants