Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eco bridge adapter with the new bridge addresses for the ECO bridges on OP and OP Goerli #6182

Merged
merged 26 commits into from
Jun 29, 2023

Conversation

tremarkley
Copy link
Contributor

In https://github.com/ethereum-optimism/ethereum-optimism.github.io/pull/387/files the addresses for the ECO bridges were updated. This change updates the ECO SDK bridge adapter to point to the new addresses.

@tremarkley tremarkley requested a review from a team as a code owner June 28, 2023 16:46
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2023

🦋 Changeset detected

Latest commit: 59abd46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@eth-optimism/sdk Patch
@eth-optimism/chain-mon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 59abd46
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/649d79e44fb7860008f88588

@mergify mergify bot added the sdk label Jun 28, 2023
@mergify mergify bot requested a review from roninjin10 June 28, 2023 16:47
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jun 28, 2023

Semgrep found 1 context-todo finding:

  • op-challenger/fault/agent.go: L55

Consider to use well-defined context

Ignore this finding from context-todo.

@tremarkley tremarkley requested a review from a team as a code owner June 28, 2023 18:39
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #6182 (59abd46) into develop (6856455) will decrease coverage by 0.31%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6182      +/-   ##
===========================================
- Coverage    44.56%   44.26%   -0.31%     
===========================================
  Files          448      448              
  Lines        29409    29409              
  Branches       691      691              
===========================================
- Hits         13107    13017      -90     
- Misses       15231    15329      +98     
+ Partials      1071     1063       -8     
Flag Coverage Δ
bedrock-go-tests 43.54% <ø> (+0.09%) ⬆️
cannon-go-tests 61.71% <ø> (ø)
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 46.87% <ø> (-11.88%) ⬇️
core-utils-tests 49.06% <ø> (ø)
fault-detector-tests 26.95% <ø> (ø)
sdk-next-tests 42.47% <ø> (ø)
sdk-tests 42.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/sdk/src/adapters/eco-bridge.ts 35.71% <ø> (ø)
packages/sdk/src/utils/chain-constants.ts 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

Copy link
Member

@nickbalestra nickbalestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it LGTM, But I would prefer for @roninjin10 to have a final pass and stamp of approval before landing this

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

Hey @tremarkley! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 29, 2023
@mergify mergify bot removed the conflict label Jun 29, 2023
@OptimismBot OptimismBot merged commit ef6fd95 into develop Jun 29, 2023
@OptimismBot OptimismBot deleted the update_eco_bridge branch June 29, 2023 15:39
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants