-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eco bridge adapter with the new bridge addresses for the ECO bridges on OP and OP Goerli #6182
Conversation
🦋 Changeset detectedLatest commit: 59abd46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for opstack-docs canceled.
|
Semgrep found 1
Consider to use well-defined context Ignore this finding from context-todo. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6182 +/- ##
===========================================
- Coverage 44.56% 44.26% -0.31%
===========================================
Files 448 448
Lines 29409 29409
Branches 691 691
===========================================
- Hits 13107 13017 -90
- Misses 15231 15329 +98
+ Partials 1071 1063 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as it LGTM, But I would prefer for @roninjin10 to have a final pass and stamp of approval before landing this
Hey @tremarkley! This PR has merge conflicts. Please fix them before continuing review. |
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
In https://github.com/ethereum-optimism/ethereum-optimism.github.io/pull/387/files the addresses for the ECO bridges were updated. This change updates the ECO SDK bridge adapter to point to the new addresses.