Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Add admin_sequencerActive RPC method #6190

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

ajsutton
Copy link
Contributor

Description

Add admin_sequencerActive RPC method.

Returns true if the node is actively sequencing, otherwise false. This is essentially a parallel with the eth_mining API from execution clients.

Tests

Updated e2e tests for admin API to cover the new endpoint.

Metadata

@ajsutton ajsutton requested review from protolambda, trianglesphere and a team as code owners June 29, 2023 01:54
@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023

⚠️ No Changeset found

Latest commit: bff6bab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit bff6bab
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/649cec4b13046c000876821d

Returns true if the node is actively sequencing, otherwise false. This is essentially a parallel with the `eth_mining` API from execution clients.
@ajsutton ajsutton force-pushed the aj/get-synch-status branch from 1a90420 to ef9c209 Compare June 29, 2023 01:58
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #6190 (bff6bab) into develop (ff6d298) will decrease coverage by 1.15%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6190      +/-   ##
===========================================
- Coverage    44.69%   43.54%   -1.15%     
===========================================
  Files          448      317     -131     
  Lines        29384    24646    -4738     
  Branches       691        0     -691     
===========================================
- Hits         13132    10733    -2399     
+ Misses       15182    12921    -2261     
+ Partials      1070      992      -78     
Flag Coverage Δ
bedrock-go-tests 43.54% <0.00%> (-0.05%) ⬇️
cannon-go-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
core-utils-tests ?
fault-detector-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/node/api.go 40.74% <0.00%> (-2.12%) ⬇️
op-node/rollup/driver/driver.go 0.00% <0.00%> (ø)
op-node/rollup/driver/state.go 0.00% <0.00%> (ø)
op-node/sources/rollupclient.go 0.00% <0.00%> (ø)

... and 131 files with indirect coverage changes

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants