Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 feat: Add grafana #7221

Closed
wants to merge 1 commit into from
Closed

🔧 feat: Add grafana #7221

wants to merge 1 commit into from

Conversation

roninjin10
Copy link
Contributor

Add grafana dashboard to docker-compose of indexer

@roninjin10
Copy link
Contributor Author

roninjin10 commented Sep 13, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2023

Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added S-conflict Status: A conflict is present A-indexer Area: indexer labels Sep 13, 2023
@@ -81,6 +81,21 @@ services:
postgres:
condition: service_healthy

grafana:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service 'grafana' is running with a writable root filesystem. This may allow malicious applications to download and run additional payloads, or modify container files. If an application inside a container has to save something temporarily consider using a tmpfs. Add 'read_only: true' to this service to prevent this.

Ignore this finding from writable-filesystem-service.

ctcTxDeposits[logKey{deposit.Event.BlockHash, deposit.Event.LogIndex}] = &deposit
transactionDeposits[i] = database.L1TransactionDeposit{
SourceHash: deposit.TxHash,
L2TransactionHash: deposit.TxHash, // TODO: check that this is right
Copy link
Contributor

@semgrep-app semgrep-app bot Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a Linear ticket for this TODO.

Ignore this finding from todos_require_linear.

@roninjin10 roninjin10 changed the base branch from develop to 09-13-feat_indexer_Implement_hardcoded_tx September 13, 2023 20:03
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from f6ddb97 to 0cd7f5a Compare September 13, 2023 20:03
@mergify mergify bot removed the S-conflict Status: A conflict is present label Sep 13, 2023
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Implement_hardcoded_tx branch from a8c7647 to 434ef22 Compare September 13, 2023 20:20
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from 0cd7f5a to 5d99f5d Compare September 13, 2023 20:20
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Implement_hardcoded_tx branch from 434ef22 to 3dc9f71 Compare September 13, 2023 20:47
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from 5d99f5d to cbae581 Compare September 13, 2023 20:47
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Implement_hardcoded_tx branch from 3dc9f71 to 5b3964e Compare September 14, 2023 01:22
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from cbae581 to 9911126 Compare September 14, 2023 01:22
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Implement_hardcoded_tx branch from 5b3964e to d8190ff Compare September 14, 2023 01:34
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from 9911126 to fea37af Compare September 14, 2023 01:35
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Implement_hardcoded_tx branch from d8190ff to 76d9f71 Compare September 14, 2023 01:55
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from fea37af to fbd8ffc Compare September 14, 2023 01:55
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Implement_hardcoded_tx branch from 76d9f71 to b59ca3e Compare September 14, 2023 02:14
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from fbd8ffc to c977153 Compare September 14, 2023 02:14
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Implement_hardcoded_tx branch from b59ca3e to c81da8f Compare September 14, 2023 02:33
Base automatically changed from 09-13-feat_indexer_Implement_hardcoded_tx to develop September 14, 2023 02:43
@roninjin10 roninjin10 changed the base branch from develop to 09-13-feat_indexer_Publish_types_for_api September 14, 2023 03:27
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from c977153 to 0ec2ac0 Compare September 14, 2023 03:27
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Publish_types_for_api branch 2 times, most recently from 97884a4 to f4b6e27 Compare September 14, 2023 03:54
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Publish_types_for_api branch 3 times, most recently from 76d3e5c to b132847 Compare September 14, 2023 04:05
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Publish_types_for_api branch from b132847 to 5b67878 Compare September 14, 2023 04:18
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from 0ec2ac0 to 7e38997 Compare September 14, 2023 04:18
@roninjin10 roninjin10 force-pushed the 09-13-feat_indexer_Publish_types_for_api branch from 5b67878 to 7ff952c Compare September 14, 2023 04:21
@roninjin10 roninjin10 force-pushed the 09-12-feat_Add_grafana branch from 7e38997 to eaa96a0 Compare September 14, 2023 04:21
Base automatically changed from 09-13-feat_indexer_Publish_types_for_api to develop September 14, 2023 04:37
@roninjin10
Copy link
Contributor Author

Closing for #7257

@roninjin10 roninjin10 closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-indexer Area: indexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant